Changeset 139270 in webkit

Timestamp:

Jan 9, 2013 6:35:36 PM (11 years ago)

Author:

jparent@chromium.org

Message:

Dashboard Cleanup: Reload the page as soon as we know we need to.
​https://bugs.webkit.org/show_bug.cgi?id=106515

No need to continue parsing all of the data once we know that
we need to do a reload.

Reviewed by Dirk Pranke.

• TestResultServer/static-dashboards/dashboard_base.js:

(parseParameters):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestResultServer/static-dashboards/dashboard_base.js (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2013-01-09  Julie Parent  <jparent@chromium.org>
+
+        Dashboard Cleanup: Reload the page as soon as we know we need to.
+        https://bugs.webkit.org/show_bug.cgi?id=106515
+
+        No need to continue parsing all of the data once we know that
+        we need to do a reload.
+        
+        Reviewed by Dirk Pranke.
+
+        * TestResultServer/static-dashboards/dashboard_base.js:
+        (parseParameters):
+
 2013-01-09  Eric Seidel  <eric@webkit.org>
 

trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js

@@ -322 +322 @@
 
     parseCrossDashboardParameters();
+    
+    // Some parameters require loading different JSON files when the value changes. Do a reload.
+    if (Object.keys(oldCrossDashboardState).length) {
+        for (var key in g_crossDashboardState) {
+            if (oldCrossDashboardState[key] != g_crossDashboardState[key] && RELOAD_REQUIRING_PARAMETERS.indexOf(key) != -1) {
+                window.location.reload();
+                return {};
+            }
+        }
+    }
+
     parseDashboardSpecificParameters();
     parseParameter(queryHashAsMap(), 'builder');
@@ -337 +348 @@
     if (g_currentState.tests)
         delete g_currentState.builder;
-
-    // Some parameters require loading different JSON files when the value changes. Do a reload.
-    if (Object.keys(oldCrossDashboardState).length) {
-        for (var key in g_crossDashboardState) {
-            if (oldCrossDashboardState[key] != g_crossDashboardState[key] && RELOAD_REQUIRING_PARAMETERS.indexOf(key) != -1)
-                window.location.reload();
-        }
-    }
 
     return dashboardSpecificDiffState;