Changeset 139272 in webkit

Timestamp:

Jan 9, 2013 6:50:22 PM (11 years ago)

Author:

jparent@chromium.org

Message:

Dashboard cleanup: Remove code for currentState and window.location.hash getting out of state
​https://bugs.webkit.org/show_bug.cgi?id=106514

This is old code, as these can no longer get out of sync.
permmaLinkURLHash is generated from currentState, which is set only
from the location. The commment about how these can get out of sync
refers to a function that no longer exists.

Reviewed by Dirk Pranke.

• TestResultServer/static-dashboards/dashboard_base.js:

(handleLocationChange):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestResultServer/static-dashboards/dashboard_base.js (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2013-01-09  Julie Parent  <jparent@chromium.org>
+
+        Dashboard cleanup: Remove code for currentState and window.location.hash getting out of state
+        https://bugs.webkit.org/show_bug.cgi?id=106514
+
+        This is old code, as these can no longer get out of sync.
+        permmaLinkURLHash is generated from currentState, which is set only
+        from the location.  The commment about how these can get out of sync
+        refers to a function that no longer exists.
+        
+        Reviewed by Dirk Pranke.
+
+        * TestResultServer/static-dashboards/dashboard_base.js:
+        (handleLocationChange):
+
 2013-01-09  Julie Parent  <jparent@chromium.org>
 

trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js

@@ -515 +515 @@
         shouldGeneratePage = handleQueryParameterChange(params);
 
-    var newHash = permaLinkURLHash();
-    var winHash = window.location.hash || "#";
-    // Make sure the location is the same as the state we are using internally.
-    // These get out of sync if processQueryParamChange changed state.
-    if (newHash != winHash) {
-        // This will cause another hashchange, and when we loop
-        // back through here next time, we'll go through generatePage.
-        window.location.hash = newHash;
-    } else if (shouldGeneratePage)
+    if (shouldGeneratePage)
         generatePage();
 }