Changeset 139283 in webkit

Timestamp:

Jan 9, 2013 10:28:45 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: [Network] Data grid header and content cells are misaligned.
​https://bugs.webkit.org/show_bug.cgi?id=105795

Patch by Eugene Klyuchnikov <​eustas@chromium.org> on 2013-01-09
Reviewed by Pavel Feldman.

Header and content tables have different width -> same percent values
turn to different cell widths.

• inspector/front-end/DataGrid.js: Add "corner" cell to all rows.
• inspector/front-end/dataGrid.css: Apply "corner" rules to "td" nodes.

(.data-grid .data-container): Remove artificial padding.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/DataGrid.js (modified) (3 diffs)
• inspector/front-end/dataGrid.css (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-09  Eugene Klyuchnikov  <eustas@chromium.org>
+
+        Web Inspector: [Network] Data grid header and content cells are misaligned.
+        https://bugs.webkit.org/show_bug.cgi?id=105795
+
+        Reviewed by Pavel Feldman.
+
+        Header and content tables have different width -> same percent values
+        turn to different cell widths.
+
+        * inspector/front-end/DataGrid.js: Add "corner" cell to all rows.
+        * inspector/front-end/dataGrid.css: Apply "corner" rules to "td" nodes.
+        (.data-grid .data-container): Remove artificial padding.
+
 2013-01-09  Tien-Ren Chen  <trchen@chromium.org>
 

trunk/Source/WebCore/inspector/front-end/DataGrid.js

@@ -116 +116 @@
     columnGroup.span = this._columnCount;
 
-    var cell = document.createElement("th");
-    cell.className = "corner";
-    headerRow.appendChild(cell);
+    headerRow.createChild("th", "corner");
 
     this._headerTableColumnGroup = columnGroup;
@@ -127 +125 @@
     fillerRow.className = "filler";
 
-    for (var columnIdentifier in columns) {
-        var column = columns[columnIdentifier];
-        var td = document.createElement("td");
-        td.className = columnIdentifier + "-column";
-        fillerRow.appendChild(td);
-    }
+    for (var columnIdentifier in columns)
+        fillerRow.createChild("td", columnIdentifier + "-column");
+    fillerRow.createChild("td", "corner");
 
     this._dataTableColumnGroup = columnGroup.cloneNode(true);
@@ -1070 +1065 @@
 
         this.createCells();
+        this._element.createChild("td", "corner");
+
         return this._element;
     },

trunk/Source/WebCore/inspector/front-end/dataGrid.css

@@ -27 +27 @@
     left: 0;
     right: 0;
-    padding-right: 14px;
     overflow-x: hidden;
     overflow-y: overlay;
@@ -49 +48 @@
 }
 
-.data-grid th.corner {
+.data-grid th.corner,
+.data-grid td.corner {
     width: 14px;
     padding-right: 0px;
     padding-left: 0px;
-    border-right: 0 none transparent;
+    border-right: 0 none transparent !important;
 }
 
@@ -70 +70 @@
     left: 0;
     top: 0;
-    right: 16px;
+    right: 0;
     bottom: 0;
     height: 100%;