Changeset 139285 in webkit

Timestamp:

Jan 9, 2013 11:05:40 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Don't throw exceptions when we don't have a callstack
​https://bugs.webkit.org/show_bug.cgi?id=104849

Patch by John J. Barton <​johnjbarton@chromium.org> on 2013-01-09
Reviewed by Pavel Feldman.

Check array details.callFrames.length before accessing array;

No new tests, but this fix may help us find the cause of 'other' reasons.

• inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._debuggerPaused):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/ScriptsPanel.js (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-09  John J. Barton  <johnjbarton@chromium.org>
+
+        Web Inspector: Don't throw exceptions when we don't have a callstack
+        https://bugs.webkit.org/show_bug.cgi?id=104849
+
+        Reviewed by Pavel Feldman.
+
+        Check array details.callFrames.length before accessing array;
+
+        No new tests, but this fix may help us find the cause of 'other' reasons.
+
+        * inspector/front-end/ScriptsPanel.js:
+        (WebInspector.ScriptsPanel.prototype._debuggerPaused):
+
 2013-01-09  Eugene Klyuchnikov  <eustas@chromium.org>
 

trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js

@@ -311 +311 @@
                 this.sidebarPanes.callstack.setStatus(WebInspector.UIString("Paused on a JavaScript breakpoint."));
             }
-            details.callFrames[0].createLiveLocation(didGetUILocation.bind(this));
+            if (details.callFrames.length) 
+                details.callFrames[0].createLiveLocation(didGetUILocation.bind(this));
+            else
+                console.warn("ScriptsPanel paused, but callFrames.length is zero."); // TODO remove this once we understand this case better
         }