Changeset 139416 in webkit
- Timestamp:
- Jan 11, 2013 1:45:03 AM (11 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 6 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r139414 r139416 1 2013-01-11 Pavel Feldman <pfeldman@chromium.org> 2 3 Web Inspector [chromium]: Debugger.globalObjectCleared is not dispatched on reload after renderer swap 4 https://bugs.webkit.org/show_bug.cgi?id=106555 5 6 Reviewed by Vsevolod Vlasov. 7 8 * http/tests/inspector/debugger-test.js: 9 (initialize_DebuggerTest): 10 * inspector/debugger/debugger-scripts-reload-expected.txt: Added. 11 * inspector/debugger/debugger-scripts-reload.html: Added. 12 1 13 2013-01-11 Vsevolod Vlasov <vsevik@chromium.org> 2 14 -
trunk/LayoutTests/http/tests/inspector/debugger-test.js
r138506 r139416 285 285 for (var scriptId in WebInspector.debuggerModel._scripts) { 286 286 var script = WebInspector.debuggerModel._scripts[scriptId]; 287 if ( filter(script))287 if (!filter || filter(script)) 288 288 scripts.push(script); 289 289 } -
trunk/Source/WebCore/ChangeLog
r139414 r139416 1 2013-01-11 Pavel Feldman <pfeldman@chromium.org> 2 3 Web Inspector [chromium]: Debugger.globalObjectCleared is not dispatched on reload after renderer swap 4 https://bugs.webkit.org/show_bug.cgi?id=106555 5 6 Reviewed by Vsevolod Vlasov. 7 8 Wrong ::enable was made virtual in the InspectorDebuggerAgent. 9 10 Test: inspector/debugger/debugger-scripts-reload.html 11 12 * inspector/InspectorDebuggerAgent.h: 13 (InspectorDebuggerAgent): 14 * inspector/PageDebuggerAgent.cpp: 15 (WebCore::PageDebuggerAgent::enable): 16 (WebCore::PageDebuggerAgent::disable): 17 * inspector/PageDebuggerAgent.h: 18 (PageDebuggerAgent): 19 1 20 2013-01-11 Vsevolod Vlasov <vsevik@chromium.org> 2 21 -
trunk/Source/WebCore/inspector/InspectorDebuggerAgent.h
r138534 r139416 72 72 virtual void supportsSeparateScriptCompilationAndExecution(ErrorString*, bool*); 73 73 74 virtual void enable(ErrorString*);75 virtual void disable(ErrorString*);76 77 74 virtual void setFrontend(InspectorFrontend*); 78 75 virtual void clearFrontend(); … … 84 81 85 82 // Part of the protocol. 83 virtual void enable(ErrorString*); 84 virtual void disable(ErrorString*); 86 85 virtual void setBreakpointsActive(ErrorString*, bool active); 87 86 … … 145 144 virtual InjectedScript injectedScriptForEval(ErrorString*, const int* executionContextId) = 0; 146 145 146 virtual void enable(); 147 147 virtual void disable(); 148 148 virtual void didPause(ScriptState*, const ScriptValue& callFrames, const ScriptValue& exception); … … 151 151 152 152 private: 153 void enable();154 153 bool enabled(); 155 154 -
trunk/Source/WebCore/inspector/PageDebuggerAgent.cpp
r138457 r139416 60 60 } 61 61 62 void PageDebuggerAgent::enable( ErrorString* errorString)62 void PageDebuggerAgent::enable() 63 63 { 64 InspectorDebuggerAgent::enable( errorString);64 InspectorDebuggerAgent::enable(); 65 65 m_instrumentingAgents->setPageDebuggerAgent(this); 66 66 } 67 67 68 void PageDebuggerAgent::disable( ErrorString* errorString)68 void PageDebuggerAgent::disable() 69 69 { 70 InspectorDebuggerAgent::disable( errorString);70 InspectorDebuggerAgent::disable(); 71 71 m_instrumentingAgents->setPageDebuggerAgent(0); 72 72 } -
trunk/Source/WebCore/inspector/PageDebuggerAgent.h
r138457 r139416 50 50 virtual ~PageDebuggerAgent(); 51 51 52 virtual void enable(ErrorString*); 53 virtual void disable(ErrorString*); 52 void didClearMainFrameWindowObject(); 54 53 55 void didClearMainFrameWindowObject(); 54 protected: 55 virtual void enable(); 56 virtual void disable(); 56 57 57 58 private:
Note: See TracChangeset
for help on using the changeset viewer.