Changeset 139520 in webkit

Timestamp:

Jan 11, 2013 4:19:01 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Explicitly set msvs_cygwin_shell to true for actions in WebKit
​https://bugs.webkit.org/show_bug.cgi?id=106706

Patch by Robert Iannucci <​iannucci@chromium.org> on 2013-01-11
Reviewed by Tony Chang.

Currently, msvs_cygwin_shell is set to 1 by default. This patch
explicitly sets it on the actions which will break if msvs_cygwin_shell
were set to 0. This is in preparation for changing the default value of
msvs_cygwin_shell, which in turn is in preparation of the removal of
cygwin as a buld-system requirement.

Since this change will have no semantic effect, no new tests are
required.

• WebCore.gyp/WebCore.gyp:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• WebCore.gyp/WebCore.gyp (modified) (16 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-11  Robert Iannucci  <iannucci@chromium.org>
+
+        Explicitly set msvs_cygwin_shell to true for actions in WebKit
+        https://bugs.webkit.org/show_bug.cgi?id=106706
+
+        Reviewed by Tony Chang.
+
+        Currently, msvs_cygwin_shell is set to 1 by default. This patch
+        explicitly sets it on the actions which will break if msvs_cygwin_shell
+        were set to 0. This is in preparation for changing the default value of
+        msvs_cygwin_shell, which in turn is in preparation of the removal of
+        cygwin as a buld-system requirement.
+
+        Since this change will have no semantic effect, no new tests are
+        required.
+
+        * WebCore.gyp/WebCore.gyp:
+
 2013-01-11  Joshua Bell  <jsbell@chromium.org>
 

trunk/Source/WebCore/WebCore.gyp/WebCore.gyp

@@ -402 +402 @@
           ],
           'message': 'Generating Inspector protocol sources from Inspector.json',
+          'msvs_cygwin_shell': 1,
         },
       ]
@@ -552 +553 @@
             '<@(_inputs)',
           ],
+          'msvs_cygwin_shell': 1,
         },
       ]
@@ -709 +711 @@
             }],
           ],
+          'msvs_cygwin_shell': 1,
         },
         {
@@ -737 +740 @@
             }],
           ],
+          'msvs_cygwin_shell': 1,
         },
         {
@@ -763 +767 @@
             '--extraDefines', '<(feature_defines)'
           ],
+          'msvs_cygwin_shell': 1,
         },
         {
@@ -783 +788 @@
             '--fonts',
           ],
+          'msvs_cygwin_shell': 1,
         },
         {
@@ -810 +816 @@
             '--extraDefines', '<(feature_defines)'
           ],
+          'msvs_cygwin_shell': 1,
         },
         {
@@ -829 +836 @@
             '<@(_inputs)',
           ],
+          'msvs_cygwin_shell': 1,
         },
         {
@@ -847 +855 @@
             '<@(_inputs)',
           ],
+          'msvs_cygwin_shell': 1,
         },
         {
@@ -867 +876 @@
             '<@(_inputs)',
           ],
+          'msvs_cygwin_shell': 1,
         },
         {
@@ -891 +901 @@
             '--extraDefines', '<(feature_defines)'
           ],
+          'msvs_cygwin_shell': 1,
         },
         {
@@ -937 +948 @@
             '--defines', '<(feature_defines)',
           ],
+          'msvs_cygwin_shell': 1,
         },
         {
@@ -1034 +1046 @@
             '--extraDefines', '<(feature_defines)'
           ],
+          'msvs_cygwin_shell': 1,
         },
         {
@@ -1054 +1067 @@
             '--extraDefines', '<(feature_defines)'
           ],
+          'msvs_cygwin_shell': 1,
         },
         {
@@ -1074 +1088 @@
             '--extraDefines', '<(feature_defines)'
           ],
+          'msvs_cygwin_shell': 1,
         },
         {
@@ -1858 +1873 @@
             ['include', 'platform/graphics/harfbuzz/ng/HarfBuzzNGFaceCoreText\\.cpp$'],
             ['include', 'platform/graphics/harfbuzz/ng/HarfBuzzNGFace\\.(cpp|h)$'],
-            ['include', 'platform/graphics/harfbuzz/ng/HarfBuzzShaper\\.(cpp|h)$'],            
+            ['include', 'platform/graphics/harfbuzz/ng/HarfBuzzShaper\\.(cpp|h)$'],
           ],
         },{ # OS!="mac"