Changeset 139579 in webkit

Timestamp:

Jan 13, 2013 6:22:46 PM (11 years ago)

Author:

dpranke@chromium.org

Message:

[chromium] webkitpy-test: executive.py stringify_args error on the release test bot
​https://bugs.webkit.org/show_bug.cgi?id=105380

Reviewed by Eric Seidel.

Fix a regression introduced in r137692 where we were double-encoding
the arguments to popen(); this was only an issue on windows, where
we would try to encode something to mbcs, then try to encode it
to unicode as if the input as ascii.

• Scripts/webkitpy/common/system/executive.py:

(Executive.run_command):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/common/system/executive.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2013-01-13  Dirk Pranke  <dpranke@chromium.org>
+
+        [chromium] webkitpy-test: executive.py stringify_args error on the release test bot
+        https://bugs.webkit.org/show_bug.cgi?id=105380
+
+        Reviewed by Eric Seidel.
+
+        Fix a regression introduced in r137692 where we were double-encoding
+        the arguments to popen(); this was only an issue on windows, where
+        we would try to encode something to mbcs, then try to encode it
+        to unicode as if the input as ascii.
+
+        * Scripts/webkitpy/common/system/executive.py:
+        (Executive.run_command):
+
 2013-01-13  Alan Cutter  <alancutter@chromium.org>
 

trunk/Tools/Scripts/webkitpy/common/system/executive.py

@@ -407 +407 @@
         assert(isinstance(args, list) or isinstance(args, tuple))
         start_time = time.time()
-        args = self._stringify_args(args)
 
         stdin, string_to_communicate = self._compute_stdin(input)