Changeset 139593 in webkit


Ignore:
Timestamp:
Jan 14, 2013 1:44:20 AM (11 years ago)
Author:
commit-queue@webkit.org
Message:

Web Inspector: [Network] Add domain column
https://bugs.webkit.org/show_bug.cgi?id=106757

Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2013-01-14
Reviewed by Pavel Feldman.

Adding new column will ease domain tracking / sorting.

  • inspector/front-end/NetworkPanel.js: Added column.
  • inspector/front-end/NetworkRequest.js:

(WebInspector.NetworkRequest.prototype.get domain): Added getter.

Location:
trunk/Source/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r139591 r139593  
     12013-01-14  Eugene Klyuchnikov  <eustas@chromium.org>
     2
     3        Web Inspector: [Network] Add domain column
     4        https://bugs.webkit.org/show_bug.cgi?id=106757
     5
     6        Reviewed by Pavel Feldman.
     7
     8        Adding new column will ease domain tracking / sorting.
     9
     10        * inspector/front-end/NetworkPanel.js: Added column.
     11        * inspector/front-end/NetworkRequest.js:
     12        (WebInspector.NetworkRequest.prototype.get domain): Added getter.
     13
    1142013-01-14  Qiankun Miao  <qiankun.miao@intel.com>
    215
  • trunk/Source/WebCore/inspector/front-end/NetworkPanel.js

    r139452 r139593  
    9696}
    9797
    98 WebInspector.NetworkLogView._defaultColumnsVisivility = {method: true, status: true, type: true, initiator: true, size: true, time: true};
     98WebInspector.NetworkLogView._defaultColumnsVisivility = {method: true, status: true, domain: false, type: true, initiator: true, size: true, time: true};
    9999
    100100WebInspector.NetworkLogView.prototype = {
     
    158158    _createTable: function()
    159159    {
    160         var columns = {name: {}, method: {}, status: {}, type: {}, initiator: {}, size: {}, time: {}, timeline: {}};
     160        var columns = {name: {}, method: {}, status: {}, domain: {}, type: {}, initiator: {}, size: {}, time: {}, timeline: {}};
    161161
    162162        columns.name.titleDOMFragment = this._makeHeaderFragment(WebInspector.UIString("Name"), WebInspector.UIString("Path"));
     
    174174        columns.status.sortable = true;
    175175        columns.status.weight = 6;
     176
     177        columns.domain.title = WebInspector.UIString("Domain");
     178        columns.domain.sortable = true;
     179        columns.domain.weight = 6;
    176180
    177181        columns.type.title = WebInspector.UIString("Type");
     
    274278        this._sortingFunctions.method = WebInspector.NetworkDataGridNode.RequestPropertyComparator.bind(null, "method", false);
    275279        this._sortingFunctions.status = WebInspector.NetworkDataGridNode.RequestPropertyComparator.bind(null, "statusCode", false);
     280        this._sortingFunctions.domain = WebInspector.NetworkDataGridNode.RequestPropertyComparator.bind(null, "domain", false);
    276281        this._sortingFunctions.type = WebInspector.NetworkDataGridNode.RequestPropertyComparator.bind(null, "mimeType", false);
    277282        this._sortingFunctions.initiator = WebInspector.NetworkDataGridNode.InitiatorComparator;
     
    18801885        this._methodCell = this._createDivInTD("method");
    18811886        this._statusCell = this._createDivInTD("status");
     1887        this._domainCell = this._createDivInTD("domain");
    18821888        this._typeCell = this._createDivInTD("type");
    18831889        this._initiatorCell = this._createDivInTD("initiator");
     
    19871993
    19881994        this._refreshStatusCell();
     1995        this._refreshDomainCell();
    19891996        this._refreshTypeCell();
    19901997        this._refreshInitiatorCell();
     
    20622069            this._statusCell.addStyleClass("network-dim-cell");
    20632070        }
     2071    },
     2072
     2073    _refreshDomainCell: function()
     2074    {
     2075        this._domainCell.removeChildren();
     2076        this._domainCell.appendChild(document.createTextNode(this._request.domain));
     2077        this._domainCell.title = this._request.parsedURL.host;
    20642078    },
    20652079
  • trunk/Source/WebCore/inspector/front-end/NetworkRequest.js

    r133583 r139593  
    425425
    426426    /**
     427     * @return {string}
     428     */
     429    get domain()
     430    {
     431        return this._parsedURL.host;
     432    },
     433
     434    /**
    427435     * @return {WebInspector.Resource|undefined}
    428436     */
Note: See TracChangeset for help on using the changeset viewer.