Changeset 139601 in webkit


Ignore:
Timestamp:
Jan 14, 2013 3:10:36 AM (11 years ago)
Author:
haraken@chromium.org
Message:

[V8] Pass an Isolate to associateObjectWithWrapper()
​https://bugs.webkit.org/show_bug.cgi?id=106773

Reviewed by Adam Barth.

In preparation for making an Isolate parameter mandatory
in associateObjectWithWrapper(), this patch passes an
Isolate to associateObjectWithWrapper().

No tests. No change in behavior.

  • bindings/v8/custom/V8ArrayBufferCustom.cpp:

(WebCore::V8ArrayBuffer::constructorCallbackCustom):

  • bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::wrapArrayBufferView):
(WebCore::constructWebGLArray):

  • bindings/v8/custom/V8AudioContextCustom.cpp:

(WebCore::V8AudioContext::constructorCallbackCustom):

  • bindings/v8/custom/V8DOMFormDataCustom.cpp:

(WebCore::V8DOMFormData::constructorCallbackCustom):

  • bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::V8DataView::constructorCallbackCustom):

  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore::v8HTMLImageElementConstructorCallback):

  • bindings/v8/custom/V8IntentCustom.cpp:

(WebCore::V8Intent::constructorCallbackCustom):

  • bindings/v8/custom/V8MessageChannelCustom.cpp:

(WebCore::V8MessageChannel::constructorCallbackCustom):

  • bindings/v8/custom/V8MutationObserverCustom.cpp:

(WebCore::V8MutationObserver::constructorCallbackCustom):

  • bindings/v8/custom/V8WebKitPointCustom.cpp:

(WebCore::V8WebKitPoint::constructorCallbackCustom):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::constructorCallbackCustom):

Location:
trunk/Source/WebCore
Files:
12 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r139599 r139601  
     12013-01-14  Kentaro Hara  <haraken@chromium.org>
     2
     3        [V8] Pass an Isolate to associateObjectWithWrapper()
     4        https://bugs.webkit.org/show_bug.cgi?id=106773
     5
     6        Reviewed by Adam Barth.
     7
     8        In preparation for making an Isolate parameter mandatory
     9        in associateObjectWithWrapper(), this patch passes an
     10        Isolate to associateObjectWithWrapper().
     11
     12        No tests. No change in behavior.
     13
     14        * bindings/v8/custom/V8ArrayBufferCustom.cpp:
     15        (WebCore::V8ArrayBuffer::constructorCallbackCustom):
     16        * bindings/v8/custom/V8ArrayBufferViewCustom.h:
     17        (WebCore::wrapArrayBufferView):
     18        (WebCore::constructWebGLArray):
     19        * bindings/v8/custom/V8AudioContextCustom.cpp:
     20        (WebCore::V8AudioContext::constructorCallbackCustom):
     21        * bindings/v8/custom/V8DOMFormDataCustom.cpp:
     22        (WebCore::V8DOMFormData::constructorCallbackCustom):
     23        * bindings/v8/custom/V8DataViewCustom.cpp:
     24        (WebCore::V8DataView::constructorCallbackCustom):
     25        * bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
     26        (WebCore::v8HTMLImageElementConstructorCallback):
     27        * bindings/v8/custom/V8IntentCustom.cpp:
     28        (WebCore::V8Intent::constructorCallbackCustom):
     29        * bindings/v8/custom/V8MessageChannelCustom.cpp:
     30        (WebCore::V8MessageChannel::constructorCallbackCustom):
     31        * bindings/v8/custom/V8MutationObserverCustom.cpp:
     32        (WebCore::V8MutationObserver::constructorCallbackCustom):
     33        * bindings/v8/custom/V8WebKitPointCustom.cpp:
     34        (WebCore::V8WebKitPoint::constructorCallbackCustom):
     35        * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
     36        (WebCore::V8XMLHttpRequest::constructorCallbackCustom):
     37
    1382013-01-14  Kentaro Hara  <haraken@chromium.org>
    239

  • trunk/Source/WebCore/bindings/v8/custom/V8ArrayBufferCustom.cpp

    r136605 r139601  
    7777    // Transform the holder into a wrapper object for the array.
    7878    v8::Handle<v8::Object> wrapper = args.Holder();
    79     V8DOMWrapper::associateObjectWithWrapper(buffer.release(), &info, wrapper);
     79    V8DOMWrapper::associateObjectWithWrapper(buffer.release(), &info, wrapper, args.GetIsolate());
    8080    return wrapper;
    8181}

  • trunk/Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h

    r139459 r139601  
    5656        args.Holder()->SetIndexedPropertiesToExternalArrayData(array.get()->baseAddress(), arrayType, array.get()->length());
    5757    v8::Handle<v8::Object> wrapper = args.Holder();
    58     v8::Persistent<v8::Object> wrapperHandle = V8DOMWrapper::associateObjectWithWrapper(array.release(), type, wrapper);
     58    v8::Persistent<v8::Object> wrapperHandle = V8DOMWrapper::associateObjectWithWrapper(array.release(), type, wrapper, args.GetIsolate());
    5959    wrapperHandle.MarkIndependent();
    6060    return wrapper;
    … …  
    226226
    227227    v8::Handle<v8::Object> wrapper = args.Holder();
    228     v8::Persistent<v8::Object> wrapperHandle = V8DOMWrapper::associateObjectWithWrapper(array.release(), type, wrapper);
     228    v8::Persistent<v8::Object> wrapperHandle = V8DOMWrapper::associateObjectWithWrapper(array.release(), type, wrapper, args.GetIsolate());
    229229    wrapperHandle.MarkIndependent();
    230230    return wrapper;

  • trunk/Source/WebCore/bindings/v8/custom/V8AudioContextCustom.cpp

    r137516 r139601  
    7474    // Transform the holder into a wrapper object for the audio context.
    7575    v8::Handle<v8::Object> wrapper = args.Holder();
    76     V8DOMWrapper::associateObjectWithWrapper(audioContext.release(), &info, wrapper);
     76    V8DOMWrapper::associateObjectWithWrapper(audioContext.release(), &info, wrapper, args.GetIsolate());
    7777   
    7878    return wrapper;

  • trunk/Source/WebCore/bindings/v8/custom/V8DOMFormDataCustom.cpp

    r138677 r139601  
    4848
    4949    v8::Handle<v8::Object> wrapper = args.Holder();
    50     V8DOMWrapper::associateObjectWithWrapper(domFormData.release(), &info, wrapper);
     50    V8DOMWrapper::associateObjectWithWrapper(domFormData.release(), &info, wrapper, args.GetIsolate());
    5151    return wrapper;
    5252}

  • trunk/Source/WebCore/bindings/v8/custom/V8DataViewCustom.cpp

    r138665 r139601  
    4040        RefPtr<DataView> dataView = DataView::create(0);
    4141        v8::Handle<v8::Object> wrapper = args.Holder();
    42         V8DOMWrapper::associateObjectWithWrapper(dataView.release(), &info, wrapper);
     42        V8DOMWrapper::associateObjectWithWrapper(dataView.release(), &info, wrapper, args.GetIsolate());
    4343        return wrapper;
    4444    }

  • trunk/Source/WebCore/bindings/v8/custom/V8HTMLImageElementConstructor.cpp

    r138677 r139601  
    7878    RefPtr<HTMLImageElement> image = HTMLImageElement::createForJSConstructor(document, optionalWidth, optionalHeight);
    7979    v8::Handle<v8::Object> wrapper = args.Holder();
    80     V8DOMWrapper::associateObjectWithWrapper(image.release(), &V8HTMLImageElementConstructor::info, wrapper);
     80    V8DOMWrapper::associateObjectWithWrapper(image.release(), &V8HTMLImageElementConstructor::info, wrapper, args.GetIsolate());
    8181    return wrapper;
    8282}

  • trunk/Source/WebCore/bindings/v8/custom/V8IntentCustom.cpp

    r136605 r139601  
    5656
    5757        v8::Handle<v8::Object> wrapper = args.Holder();
    58         V8DOMWrapper::associateObjectWithWrapper(impl.release(), &info, wrapper);
     58        V8DOMWrapper::associateObjectWithWrapper(impl.release(), &info, wrapper, args.GetIsolate());
    5959        return wrapper;
    6060    }
    … …  
    7979
    8080    v8::Handle<v8::Object> wrapper = args.Holder();
    81     V8DOMWrapper::associateObjectWithWrapper(impl.release(), &info, wrapper);
     81    V8DOMWrapper::associateObjectWithWrapper(impl.release(), &info, wrapper, args.GetIsolate());
    8282    return wrapper;
    8383}

  • trunk/Source/WebCore/bindings/v8/custom/V8MessageChannelCustom.cpp

    r136605 r139601  
    5858    V8DOMWrapper::setNamedHiddenReference(wrapper, "port2", toV8(obj->port2(), args.Holder(), args.GetIsolate()));
    5959
    60     V8DOMWrapper::associateObjectWithWrapper(obj.release(), &info, wrapper);
     60    V8DOMWrapper::associateObjectWithWrapper(obj.release(), &info, wrapper, args.GetIsolate());
    6161    return wrapper;
    6262}

  • trunk/Source/WebCore/bindings/v8/custom/V8MutationObserverCustom.cpp

    r138811 r139601  
    5757    RefPtr<MutationObserver> observer = MutationObserver::create(callback.release());
    5858
    59     V8DOMWrapper::associateObjectWithWrapper(observer.release(), &info, wrapper);
     59    V8DOMWrapper::associateObjectWithWrapper(observer.release(), &info, wrapper, args.GetIsolate());
    6060    return wrapper;
    6161}

  • trunk/Source/WebCore/bindings/v8/custom/V8WebKitPointCustom.cpp

    r136605 r139601  
    5858    RefPtr<WebKitPoint> point = WebKitPoint::create(x, y);
    5959    v8::Handle<v8::Object> wrapper = args.Holder();
    60     V8DOMWrapper::associateObjectWithWrapper(point.release(), &info, wrapper);
     60    V8DOMWrapper::associateObjectWithWrapper(point.release(), &info, wrapper, args.GetIsolate());
    6161    return wrapper;
    6262}

  • trunk/Source/WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp

    r138665 r139601  
    6262
    6363    v8::Handle<v8::Object> wrapper = args.Holder();
    64     V8DOMWrapper::associateObjectWithWrapper(xmlHttpRequest.release(), &info, wrapper);
     64    V8DOMWrapper::associateObjectWithWrapper(xmlHttpRequest.release(), &info, wrapper, args.GetIsolate());
    6565    return wrapper;
    6666}
Note: See TracChangeset for help on using the changeset viewer.