Changeset 139605 in webkit

Timestamp:

Jan 14, 2013 4:05:58 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: InspectorTest.createTestEditor should not set any text in editor
​https://bugs.webkit.org/show_bug.cgi?id=106772

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-01-14
Reviewed by Pavel Feldman.

Add InspectorTest.fillEditorWithText helper method and remove this
functionality from InspectorTest.createTestEditor method.

• inspector/editor/editor-test.js:

(initialize_EditorTests.InspectorTest.createTestEditor): Removed functionality for setting editor text.
(initialize_EditorTests.InspectorTest.fillEditorWithText): Added.

• inspector/editor/text-editor-remove-chunks-from-dom.html:
• inspector/editor/text-editor-selection.html:
• inspector/editor/text-editor-type-over-decoration.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• inspector/editor/editor-test.js (modified) (3 diffs)
• inspector/editor/text-editor-remove-chunks-from-dom.html (modified) (1 diff)
• inspector/editor/text-editor-selection.html (modified) (1 diff)
• inspector/editor/text-editor-type-over-decoration.html (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-01-14  Andrey Lushnikov  <lushnikov@chromium.org>
+
+        Web Inspector: InspectorTest.createTestEditor should not set any text in editor
+        https://bugs.webkit.org/show_bug.cgi?id=106772
+
+        Reviewed by Pavel Feldman.
+
+        Add InspectorTest.fillEditorWithText helper method and remove this
+        functionality from InspectorTest.createTestEditor method.
+
+        * inspector/editor/editor-test.js:
+        (initialize_EditorTests.InspectorTest.createTestEditor): Removed functionality for setting editor text.
+        (initialize_EditorTests.InspectorTest.fillEditorWithText): Added.
+        * inspector/editor/text-editor-remove-chunks-from-dom.html:
+        * inspector/editor/text-editor-selection.html:
+        * inspector/editor/text-editor-type-over-decoration.html:
+
 2013-01-14  Csaba Osztrogonác  <ossy@webkit.org>
 

trunk/LayoutTests/inspector/editor/editor-test.js

@@ -2 +2 @@
 {
 
-InspectorTest.createTestEditor = function(lineCount, clientHeight, chunkSize)
+InspectorTest.createTestEditor = function(clientHeight, chunkSize)
 {
     WebInspector.debugDefaultTextEditor = true;
@@ -8 +8 @@
     textEditor.overrideViewportForTest(0, clientHeight || 100, chunkSize || 10);
     textEditor.show(WebInspector.inspectorView.element);
+    return textEditor;
+};
+
+InspectorTest.fillEditorWithText = function(textEditor, lineCount)
+{
     var textModel = textEditor._textModel;
     var lines = [];
@@ -13 +18 @@
         lines.push(i);
     textModel.setText(lines.join("\n"));
-    return textEditor;
-};
+}
 
 InspectorTest.dumpEditorChunks = function(textEditor)

trunk/LayoutTests/inspector/editor/text-editor-remove-chunks-from-dom.html

@@ -10 +10 @@
         function testDamageLastChunk(next)
         {
-            var textEditor = InspectorTest.createTestEditor(5);
+            var textEditor = InspectorTest.createTestEditor();
+            InspectorTest.fillEditorWithText(textEditor, 5);
             textEditor.setText(textEditor.text() + "\n");
             InspectorTest.addResult("\nBefore editing");

trunk/LayoutTests/inspector/editor/text-editor-selection.html

@@ -7 +7 @@
 function test()
 {
-    var textEditor = InspectorTest.createTestEditor(34);
+    var textEditor = InspectorTest.createTestEditor();
+    InspectorTest.fillEditorWithText(textEditor, 34);
     InspectorTest.dumpEditorChunks(textEditor);
 

trunk/LayoutTests/inspector/editor/text-editor-type-over-decoration.html

@@ -7 +7 @@
 function test()
 {
-    var textEditor = InspectorTest.createTestEditor(10);
+    var textEditor = InspectorTest.createTestEditor();
+    InspectorTest.fillEditorWithText(textEditor, 10);
     var textModel = textEditor._textModel;