Changeset 139619 in webkit


Ignore:
Timestamp:
Jan 14, 2013 9:30:59 AM (11 years ago)
Author:
haraken@chromium.org
Message:

[V8] Make an Isolate parameter mandatory in wrap()
​https://bugs.webkit.org/show_bug.cgi?id=106783

Reviewed by Adam Barth.

Now it's safe to make an Isolate parameter in wrap().

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):

  • bindings/scripts/test/V8/V8Float64Array.h:

(WebCore):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(WebCore::wrap):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(WebCore::wrap):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(WebCore::wrap):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(WebCore::wrap):

  • bindings/scripts/test/V8/V8TestException.h:

(WebCore::wrap):

  • bindings/scripts/test/V8/V8TestInterface.h:

(WebCore::wrap):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(WebCore::wrap):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(WebCore::wrap):

  • bindings/scripts/test/V8/V8TestNode.h:

(WebCore::wrap):

  • bindings/scripts/test/V8/V8TestObj.h:

(WebCore::wrap):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.h:

(WebCore::wrap):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(WebCore::wrap):

Location:
trunk/Source/WebCore
Files:
15 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r139618 r139619  
     12013-01-14  Kentaro Hara  <haraken@chromium.org>
     2
     3        [V8] Make an Isolate parameter mandatory in wrap()
     4        https://bugs.webkit.org/show_bug.cgi?id=106783
     5
     6        Reviewed by Adam Barth.
     7
     8        Now it's safe to make an Isolate parameter in wrap().
     9
     10        No tests. No change in behavior.
     11
     12        * bindings/scripts/CodeGeneratorV8.pm:
     13        (GenerateHeader):
     14        * bindings/scripts/test/V8/V8Float64Array.h:
     15        (WebCore):
     16        * bindings/scripts/test/V8/V8TestActiveDOMObject.h:
     17        (WebCore::wrap):
     18        * bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
     19        (WebCore::wrap):
     20        * bindings/scripts/test/V8/V8TestEventConstructor.h:
     21        (WebCore::wrap):
     22        * bindings/scripts/test/V8/V8TestEventTarget.h:
     23        (WebCore::wrap):
     24        * bindings/scripts/test/V8/V8TestException.h:
     25        (WebCore::wrap):
     26        * bindings/scripts/test/V8/V8TestInterface.h:
     27        (WebCore::wrap):
     28        * bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
     29        (WebCore::wrap):
     30        * bindings/scripts/test/V8/V8TestNamedConstructor.h:
     31        (WebCore::wrap):
     32        * bindings/scripts/test/V8/V8TestNode.h:
     33        (WebCore::wrap):
     34        * bindings/scripts/test/V8/V8TestObj.h:
     35        (WebCore::wrap):
     36        * bindings/scripts/test/V8/V8TestOverloadedConstructors.h:
     37        (WebCore::wrap):
     38        * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
     39        (WebCore::wrap):
     40
    1412013-01-14  Tommy Widenflycht  <tommyw@google.com>
    242

  • trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm

    r139599 r139619  
    546546            push(@headerContent, <<END);
    547547
    548 v8::Handle<v8::Object> wrap(${nativeType}* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* = 0);
     548v8::Handle<v8::Object> wrap(${nativeType}* impl, v8::Handle<v8::Object> creationContext, v8::Isolate*);
    549549END
    550550        } else {
    551551            push(@headerContent, <<END);
    552552
    553 inline v8::Handle<v8::Object> wrap(${nativeType}* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
     553inline v8::Handle<v8::Object> wrap(${nativeType}* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
    554554{
    555555    ASSERT(impl);

  • trunk/Source/WebCore/bindings/scripts/test/V8/V8Float64Array.h

    r136652 r139619  
    5555
    5656
    57 v8::Handle<v8::Object> wrap(Float64Array* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* = 0);
     57v8::Handle<v8::Object> wrap(Float64Array* impl, v8::Handle<v8::Object> creationContext, v8::Isolate*);
    5858
    5959inline v8::Handle<v8::Value> toV8(Float64Array* impl, v8::Handle<v8::Object> creationContext = v8::Handle<v8::Object>(), v8::Isolate* isolate = 0)

  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestActiveDOMObject.h

    r136652 r139619  
    5555
    5656
    57 inline v8::Handle<v8::Object> wrap(TestActiveDOMObject* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
     57inline v8::Handle<v8::Object> wrap(TestActiveDOMObject* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
    5858{
    5959    ASSERT(impl);

  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestCustomNamedGetter.h

    r136652 r139619  
    5454
    5555
    56 inline v8::Handle<v8::Object> wrap(TestCustomNamedGetter* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
     56inline v8::Handle<v8::Object> wrap(TestCustomNamedGetter* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
    5757{
    5858    ASSERT(impl);

  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventConstructor.h

    r136652 r139619  
    5555
    5656
    57 inline v8::Handle<v8::Object> wrap(TestEventConstructor* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
     57inline v8::Handle<v8::Object> wrap(TestEventConstructor* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
    5858{
    5959    ASSERT(impl);

  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventTarget.h

    r136652 r139619  
    5656
    5757
    58 inline v8::Handle<v8::Object> wrap(TestEventTarget* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
     58inline v8::Handle<v8::Object> wrap(TestEventTarget* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
    5959{
    6060    ASSERT(impl);

  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestException.h

    r136652 r139619  
    5353
    5454
    55 inline v8::Handle<v8::Object> wrap(TestException* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
     55inline v8::Handle<v8::Object> wrap(TestException* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
    5656{
    5757    ASSERT(impl);

  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.h

    r136652 r139619  
    5858
    5959
    60 inline v8::Handle<v8::Object> wrap(TestInterface* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
     60inline v8::Handle<v8::Object> wrap(TestInterface* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
    6161{
    6262    ASSERT(impl);

  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestMediaQueryListListener.h

    r136652 r139619  
    5353
    5454
    55 inline v8::Handle<v8::Object> wrap(TestMediaQueryListListener* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
     55inline v8::Handle<v8::Object> wrap(TestMediaQueryListListener* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
    5656{
    5757    ASSERT(impl);

  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNamedConstructor.h

    r136652 r139619  
    6060
    6161
    62 inline v8::Handle<v8::Object> wrap(TestNamedConstructor* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
     62inline v8::Handle<v8::Object> wrap(TestNamedConstructor* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
    6363{
    6464    ASSERT(impl);

  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNode.h

    r136652 r139619  
    5454
    5555
    56 inline v8::Handle<v8::Object> wrap(TestNode* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
     56inline v8::Handle<v8::Object> wrap(TestNode* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
    5757{
    5858    ASSERT(impl);

  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.h

    r136652 r139619  
    5959
    6060
    61 inline v8::Handle<v8::Object> wrap(TestObj* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
     61inline v8::Handle<v8::Object> wrap(TestObj* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
    6262{
    6363    ASSERT(impl);

  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestOverloadedConstructors.h

    r136652 r139619  
    5858
    5959
    60 inline v8::Handle<v8::Object> wrap(TestOverloadedConstructors* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
     60inline v8::Handle<v8::Object> wrap(TestOverloadedConstructors* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
    6161{
    6262    ASSERT(impl);

  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h

    r136652 r139619  
    5656
    5757
    58 inline v8::Handle<v8::Object> wrap(TestSerializedScriptValueInterface* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
     58inline v8::Handle<v8::Object> wrap(TestSerializedScriptValueInterface* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
    5959{
    6060    ASSERT(impl);
Note: See TracChangeset for help on using the changeset viewer.