Changeset 139634 in webkit

Timestamp:

Jan 14, 2013 11:43:42 AM (11 years ago)

Author:

yurys@chromium.org

Message:

[REGRESSION] Dev Tools popup for Workers forgets sizes/shows tiny in top left
​https://bugs.webkit.org/show_bug.cgi?id=106807

Reviewed by Pavel Feldman.

Open dedicated worker inspector 600x600 by default and remember its size
after resizing.

• inspector/front-end/Settings.js:
• inspector/front-end/WorkerManager.js:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/Settings.js (modified) (1 diff)
• inspector/front-end/WorkerManager.js (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-14  Yury Semikhatsky  <yurys@chromium.org>
+
+        [REGRESSION] Dev Tools popup for Workers forgets sizes/shows tiny in top left
+        https://bugs.webkit.org/show_bug.cgi?id=106807
+
+        Reviewed by Pavel Feldman.
+
+        Open dedicated worker inspector 600x600 by default and remember its size
+        after resizing.
+
+        * inspector/front-end/Settings.js:
+        * inspector/front-end/WorkerManager.js:
+
 2013-01-14  Kentaro Hara  <haraken@chromium.org>
 

trunk/Source/WebCore/inspector/front-end/Settings.js

@@ -116 +116 @@
     this.emulatedCSSMedia = this.createSetting("emulatedCSSMedia", "print");
     this.showToolbarIcons = this.createSetting("showToolbarIcons", false);
+    this.workerInspectorWidth = this.createSetting("workerInspectorWidth", 600);
+    this.workerInspectorHeight = this.createSetting("workerInspectorHeight", 600);
 
     // If there are too many breakpoints in a storage, it is likely due to a recent bug that caused

trunk/Source/WebCore/inspector/front-end/WorkerManager.js

@@ -172 +172 @@
         url = url.replace("docked=true&", "");
         url += hash;
+        var width = WebInspector.settings.workerInspectorWidth.get();
+        var height = WebInspector.settings.workerInspectorHeight.get();
         // Set location=0 just to make sure the front-end will be opened in a separate window, not in new tab.
-        var workerInspectorWindow = window.open(url, undefined, "location=0");
+        var workerInspectorWindow = window.open(url, undefined, "location=0,width=" + width + ",height=" + height);
+        workerInspectorWindow.addEventListener("resize", this._onWorkerInspectorResize.bind(this, workerInspectorWindow), false);
         this._workerIdToWindow[workerId] = workerInspectorWindow;
         workerInspectorWindow.addEventListener("beforeunload", this._workerInspectorClosing.bind(this, workerId), true);
@@ -203 +206 @@
             WorkerAgent.disconnectFromWorker(parseInt(workerId, 10));
         }
+    },
+
+    _onWorkerInspectorResize: function(workerInspectorWindow)
+    {
+        var doc = workerInspectorWindow.document;
+        WebInspector.settings.workerInspectorWidth.set(doc.width);
+        WebInspector.settings.workerInspectorHeight.set(doc.height);
     },