Changeset 139636 in webkit


Ignore:
Timestamp:
Jan 14, 2013 11:53:42 AM (11 years ago)
Author:
tony@chromium.org
Message:

Layout Test editing/spelling/spellcheck-sequencenum.html is flaky on Debug Win Chromium Bot
​https://bugs.webkit.org/show_bug.cgi?id=106806

Reviewed by Levi Weintraub.

This test manually calls waitUntilDone and uses js-test-pre.js/js-test-post.js. This confuses
the timing of the "PASS successfullyParsed is true" output. Fix this by using the helper
functions in js-test-pre.js for waitUntilDone/notifyDone.

  • editing/spelling/spellcheck-sequencenum-expected.txt:
  • editing/spelling/spellcheck-sequencenum.html:
  • platform/win/editing/spelling/spellcheck-sequencenum-expected.txt: Removed.
Location:
trunk/LayoutTests
Files:
1 deleted
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r139626 r139636  
     12013-01-14  Tony Chang  <tony@chromium.org>
     2
     3        Layout Test editing/spelling/spellcheck-sequencenum.html is flaky on Debug Win Chromium Bot
     4        https://bugs.webkit.org/show_bug.cgi?id=106806
     5
     6        Reviewed by Levi Weintraub.
     7
     8        This test manually calls waitUntilDone and uses js-test-pre.js/js-test-post.js. This confuses
     9        the timing of the "PASS successfullyParsed is true" output. Fix this by using the helper
     10        functions in js-test-pre.js for waitUntilDone/notifyDone.
     11
     12        * editing/spelling/spellcheck-sequencenum-expected.txt:
     13        * editing/spelling/spellcheck-sequencenum.html:
     14        * platform/win/editing/spelling/spellcheck-sequencenum-expected.txt: Removed.
     15
    1162013-01-14  Levi Weintraub  <leviw@chromium.org>
    217

  • trunk/LayoutTests/editing/spelling/spellcheck-sequencenum-expected.txt

    r102231 r139636  
    44
    55
     6PASS SpellCheck sequence seems working correctly.
     7PASS SpellCheck sequence seems working correctly.
     8PASS SpellCheck sequence seems working correctly.
    69PASS successfullyParsed is true
    710
    811TEST COMPLETE
    9 PASS SpellCheck sequence seems working correctly.
    10 PASS SpellCheck sequence seems working correctly.
    11 PASS SpellCheck sequence seems working correctly.
    1212

  • trunk/LayoutTests/editing/spelling/spellcheck-sequencenum.html

    r120173 r139636  
    1212
    1313if (window.testRunner) {
    14     testRunner.waitUntilDone();
     14    window.jsTestIsAsync = true;
    1515    testRunner.setAsynchronousSpellCheckingEnabled(true);
    1616}
    … …  
    8080    if (window.testRunner) {
    8181        testRunner.setAsynchronousSpellCheckingEnabled(false);
    82         testRunner.notifyDone();
     82        finishJSTest();
    8383    }
    8484}
Note: See TracChangeset for help on using the changeset viewer.