Changeset 139642 in webkit

Timestamp:

Jan 14, 2013 12:35:36 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Use correct size for DrawingBuffer readback
​https://bugs.webkit.org/show_bug.cgi?id=106744

Patch by John Bauman <​jbauman@chromium.org> on 2013-01-14
Reviewed by Kenneth Russell.

The value getInternalFramebufferSize is bogus if there's a
DrawingBuffer, so use size() instead.

• platform/graphics/chromium/DrawingBufferChromium.cpp:

(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/chromium/DrawingBufferChromium.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-14  John Bauman  <jbauman@chromium.org>
+
+        Use correct size for DrawingBuffer readback
+        https://bugs.webkit.org/show_bug.cgi?id=106744
+
+        Reviewed by Kenneth Russell.
+
+        The value getInternalFramebufferSize is bogus if there's a
+        DrawingBuffer, so use size() instead.
+
+        * platform/graphics/chromium/DrawingBufferChromium.cpp:
+        (WebCore::DrawingBuffer::paintCompositedResultsToCanvas):
+
 2013-01-14  Joshua Bell  <jsbell@chromium.org>
 

trunk/Source/WebCore/platform/graphics/chromium/DrawingBufferChromium.cpp

@@ -235 +235 @@
         return;
 
-    IntSize framebufferSize = m_context->getInternalFramebufferSize();
-
     // Since we're using the same context as WebGL, we have to restore any state we change (in this case, just the framebuffer binding).
     // FIXME: The WebGLRenderingContext tracks the current framebuffer binding, it would be slightly more efficient to use this value
@@ -248 +246 @@
 
     Extensions3DChromium* extensions = static_cast<Extensions3DChromium*>(m_context->getExtensions());
-    extensions->paintFramebufferToCanvas(framebuffer, framebufferSize.width(), framebufferSize.height(), !m_context->getContextAttributes().premultipliedAlpha, imageBuffer);
+    extensions->paintFramebufferToCanvas(framebuffer, size().width(), size().height(), !m_context->getContextAttributes().premultipliedAlpha, imageBuffer);
     m_context->deleteFramebuffer(framebuffer);