Changeset 139664 in webkit

Timestamp:

Jan 14, 2013 2:23:06 PM (11 years ago)

Author:

jchaffraix@webkit.org

Message:

REGRESSION (r132591): Underpainting @ uofmchildrenshospital.org
​https://bugs.webkit.org/show_bug.cgi?id=105861

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/repaint/overhanging-float-detach-repaint.html

The issue comes from overhanging float not contributing to their containing block's
overflow. This meant that repaint() would ignore them leading to an under-repaint.
The fix is simple: force all the overhanging floats to repaint themselves.

• rendering/RenderObject.cpp:

(WebCore::RenderObject::destroyAndCleanupAnonymousWrappers):

LayoutTests:

• fast/repaint/overhanging-float-detach-repaint-expected.png: Added.
• fast/repaint/overhanging-float-detach-repaint-expected.txt: Added.
• fast/repaint/overhanging-float-detach-repaint.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/repaint/overhanging-float-detach-repaint-expected.png (added)
• LayoutTests/fast/repaint/overhanging-float-detach-repaint-expected.txt (added)
• LayoutTests/fast/repaint/overhanging-float-detach-repaint.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderObject.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-01-14  Julien Chaffraix  <jchaffraix@webkit.org>
+
+        REGRESSION (r132591): Underpainting @ uofmchildrenshospital.org
+        https://bugs.webkit.org/show_bug.cgi?id=105861
+
+        Reviewed by David Hyatt.
+
+        * fast/repaint/overhanging-float-detach-repaint-expected.png: Added.
+        * fast/repaint/overhanging-float-detach-repaint-expected.txt: Added.
+        * fast/repaint/overhanging-float-detach-repaint.html: Added.
+
 2013-01-14  Dominic Mazzoni  <dmazzoni@google.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-14  Julien Chaffraix  <jchaffraix@webkit.org>
+
+        REGRESSION (r132591): Underpainting @ uofmchildrenshospital.org
+        https://bugs.webkit.org/show_bug.cgi?id=105861
+
+        Reviewed by David Hyatt.
+
+        Test: fast/repaint/overhanging-float-detach-repaint.html
+
+        The issue comes from overhanging float not contributing to their containing block's
+        overflow. This meant that repaint() would ignore them leading to an under-repaint.
+        The fix is simple: force all the overhanging floats to repaint themselves.
+
+        * rendering/RenderObject.cpp:
+        (WebCore::RenderObject::destroyAndCleanupAnonymousWrappers):
+
 2013-01-14  Dominic Mazzoni  <dmazzoni@google.com>
 

trunk/Source/WebCore/rendering/RenderObject.cpp

@@ -2529 +2529 @@
         if (destroyRoot->isBody())
             destroyRoot->view()->repaint();
-        else
+        else {
             destroyRoot->repaint();
+            destroyRoot->repaintOverhangingFloats(true);
+        }
     }