Changeset 139673 in webkit

Timestamp:

Jan 14, 2013 3:02:19 PM (11 years ago)

Author:

arko@motorola.com

Message:

Microdata: REGRESSION(r138725): Causes crash in chromium port
​https://bugs.webkit.org/show_bug.cgi?id=106828

Reviewed by Ryosuke Niwa.

Source/WebCore:

We should hold PropertyNodeList in RefPtr<PropertyNodeList>.

Test: fast/dom/MicroData/propertiescollection-crash.html

• bindings/v8/custom/V8HTMLCollectionCustom.cpp:

(WebCore::V8HTMLCollection::namedPropertyGetter):

LayoutTests:

• fast/dom/MicroData/propertiescollection-crash-expected.txt: Added.
• fast/dom/MicroData/propertiescollection-crash.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/dom/MicroData/propertiescollection-crash-expected.txt (added)
• LayoutTests/fast/dom/MicroData/propertiescollection-crash.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/bindings/v8/custom/V8HTMLCollectionCustom.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-01-14  Arko Saha  <arko@motorola.com>
+
+        Microdata: REGRESSION(r138725): Causes crash in chromium port
+        https://bugs.webkit.org/show_bug.cgi?id=106828
+
+        Reviewed by Ryosuke Niwa.
+
+        * fast/dom/MicroData/propertiescollection-crash-expected.txt: Added.
+        * fast/dom/MicroData/propertiescollection-crash.html: Added.
+
 2013-01-14  Stephen Chenney  <schenney@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-14  Arko Saha  <arko@motorola.com>
+
+        Microdata: REGRESSION(r138725): Causes crash in chromium port
+        https://bugs.webkit.org/show_bug.cgi?id=106828
+
+        Reviewed by Ryosuke Niwa.
+
+        We should hold PropertyNodeList in RefPtr<PropertyNodeList>.
+
+        Test: fast/dom/MicroData/propertiescollection-crash.html
+
+        * bindings/v8/custom/V8HTMLCollectionCustom.cpp:
+        (WebCore::V8HTMLCollection::namedPropertyGetter):
+
 2013-01-14  Tien-Ren Chen  <trchen@chromium.org>
 

trunk/Source/WebCore/bindings/v8/custom/V8HTMLCollectionCustom.cpp

@@ -55 +55 @@
 #if ENABLE(MICRODATA)
     if (imp->type() == ItemProperties) {
-        PropertyNodeList* item = static_cast<HTMLPropertiesCollection*>(imp)->propertyNodeList(toWebCoreAtomicString(name)).get();
+        RefPtr<PropertyNodeList> item = static_cast<HTMLPropertiesCollection*>(imp)->propertyNodeList(toWebCoreAtomicString(name));
         if (!item)
             return v8Undefined();
-        return toV8(item, info.Holder(), info.GetIsolate());
+        return toV8(item.release(), info.Holder(), info.GetIsolate());
     }
 #endif