Changeset 139693 in webkit

Timestamp:

Jan 14, 2013 5:19:14 PM (11 years ago)

Author:

ojan@chromium.org

Message:

RenderListItem does not need to override computePreferredLogicalWidth
​https://bugs.webkit.org/show_bug.cgi?id=106839

Reviewed by Levi Weintraub.

Apparently there was a time when the list marker was considered part of
the list item's preferred width, but that is no longer the case.
This code was added in r3421. The code around preferred widths has change
a lot since then.

• rendering/RenderListItem.cpp:
• rendering/RenderListItem.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderListItem.cpp (modified) (1 diff)
• rendering/RenderListItem.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-14  Ojan Vafai  <ojan@chromium.org>
+
+        RenderListItem does not need to override computePreferredLogicalWidth
+        https://bugs.webkit.org/show_bug.cgi?id=106839
+
+        Reviewed by Levi Weintraub.
+
+        Apparently there was a time when the list marker was considered part of
+        the list item's preferred width, but that is no longer the case.
+        This code was added in r3421. The code around preferred widths has change
+        a lot since then.
+
+        * rendering/RenderListItem.cpp:
+        * rendering/RenderListItem.h:
+
 2013-01-14  Dima Gorbik  <dgorbik@apple.com>
 

trunk/Source/WebCore/rendering/RenderListItem.cpp

@@ -273 +273 @@
         }
     }
-}
-
-void RenderListItem::computePreferredLogicalWidths()
-{
-    ASSERT(preferredLogicalWidthsDirty());
-    
-    updateMarkerLocation();
-
-    RenderBlock::computePreferredLogicalWidths();
 }
 

trunk/Source/WebCore/rendering/RenderListItem.h

@@ -66 +66 @@
 
     virtual void layout();
-    virtual void computePreferredLogicalWidths();
 
     void positionListMarker();