Changeset 139703 in webkit


Ignore:
Timestamp:
Jan 14, 2013 6:49:41 PM (11 years ago)
Author:
rafaelw@chromium.org
Message:

fast/dom/HTMLTemplateElement/inertContents.html is flaky on Debug Chromium bots
​https://bugs.webkit.org/show_bug.cgi?id=106810

Reviewed by Levi Weintraub.

This patch reverts the test for inertContents back to a non-flaky version which did not
attempt to assert that images are prevented from loaded.

  • fast/dom/HTMLTemplateElement/inertContents-expected.txt:
  • fast/dom/HTMLTemplateElement/inertContents.html:
  • platform/chromium/TestExpectations:
  • platform/efl/fast/dom/HTMLTemplateElement/inertContents-expected.txt: Removed.
Location:
trunk/LayoutTests
Files:
1 deleted
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r139699 r139703  
     12013-01-14  Rafael Weinstein  <rafaelw@chromium.org>
     2
     3        fast/dom/HTMLTemplateElement/inertContents.html is flaky on Debug Chromium bots
     4        https://bugs.webkit.org/show_bug.cgi?id=106810
     5
     6        Reviewed by Levi Weintraub.
     7
     8        This patch reverts the test for inertContents back to a non-flaky version which did not
     9        attempt to assert that images are prevented from loaded.
     10
     11        * fast/dom/HTMLTemplateElement/inertContents-expected.txt:
     12        * fast/dom/HTMLTemplateElement/inertContents.html:
     13        * platform/chromium/TestExpectations:
     14        * platform/efl/fast/dom/HTMLTemplateElement/inertContents-expected.txt: Removed.
     15
    1162013-01-14  Levi Weintraub  <leviw@chromium.org>
    217

  • trunk/LayoutTests/fast/dom/HTMLTemplateElement/inertContents-expected.txt

    r139502 r139703  
    1 http://foo.com/shouldLoad.jpg - willSendRequest <NSURLRequest URL http://foo.com/shouldLoad.jpg, main document URL inertContents.html, http method GET> redirectResponse (null)
    2 Blocked access to external URL http://foo.com/shouldLoad.jpg
    3 http://foo.com/shouldLoad.jpg - didFailLoadingWithError: <NSError domain NSURLErrorDomain, code -999, failing URL "(null)">
    4 The test asserts that elements within template contents are "inert", e.g. resources do not fetch, script does not run.
     1The test asserts that elements within template contents are "inert", e.g. script does not run.
    52
    6 Before template content insertion: script did not run, after template content insertion: script did run.
     3On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
    74
     5
     6PASS testVal is "script has not run"
     7PASS testVal is "script has run"
     8PASS successfullyParsed is true
     9
     10TEST COMPLETE
     11

  • trunk/LayoutTests/fast/dom/HTMLTemplateElement/inertContents.html

    r139502 r139703  
     1<!DOCTYPE html>
    12<body>
    2 <p>The test asserts that elements within template contents are "inert", e.g. resources do not fetch, script does not run.</p>
    3 <template id="template"><script>window.testVal = "script did run";</script><img src="http://foo.com/shouldNotLoad.jpg"></template>
    4 <div id="output">
    5 </div>
    6 
     3<script src="../../js/resources/js-test-pre.js"></script>
    74<script>
    8 var testVal = "script did not run";
    9 
    10 window.onload = function() {
    11     if (window.testRunner) {
    12         testRunner.dumpAsText();
    13         testRunner.dumpResourceLoadCallbacks();
    14     }
    15 
    16     var output = document.getElementById('output');
    17     output.innerHTML = 'Before template content insertion: ' + testVal;
    18    
    19     var templateContent = document.getElementById('template').content;
    20     var img = templateContent.childNodes[1];
    21     img.src = "http://foo.com/shouldLoad.jpg";
    22     document.body.appendChild(templateContent);
    23 
    24     output.innerHTML += ', after template content insertion: ' + testVal + '.';
    25 }
     5var testVal = 'script has not run';
    266</script>
    27 </head>
    28 <body>
     7<!-- FIXME: Add non-flaky test for <img> tags -->
     8<template><script>window.testVal = 'script has run';</script></template>
     9<script>
     10description('The test asserts that elements within template contents are "inert", e.g. script does not run.');
     11shouldBeEqualToString('testVal', 'script has not run');
     12var templateContent = document.querySelector('template').content;
     13document.body.appendChild(templateContent);
     14shouldBeEqualToString('testVal', 'script has run');
     15</script>
     16<script src="../../js/resources/js-test-post.js"></script>
    2917</body>

  • trunk/LayoutTests/platform/chromium/TestExpectations

    r139677 r139703  
    43664366Bug(schenney) svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t.svg [ ImageOnlyFailure ]
    43674367
    4368 webkit.org/b/106810 [ Debug ] fast/dom/HTMLTemplateElement/inertContents.html [ Pass Failure ]
    43694368webkit.org/b/106833 fast/borders/outline-alpha-inline.html [ Pass ImageOnlyFailure ]
Note: See TracChangeset for help on using the changeset viewer.