Changeset 139723 in webkit

Timestamp:

Jan 15, 2013 12:30:34 AM (11 years ago)

Author:

rniwa@webkit.org

Message:

platform/mac/accessibility/progressbar.html fails on Mac WK1 and WK2
​https://bugs.webkit.org/show_bug.cgi?id=106850

Reviewed by Chris Fleizach.

The bug was caused by some callers of supportsFocus directly calling that of Node.
Fixed the bug by calling HTMLElement's so that the virtual function on Element gets
called as needed.

• html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::supportsFocus):

• html/HTMLOutputElement.cpp:

(WebCore::HTMLOutputElement::supportsFocus):

• html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::supportsFocus):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLMeterElement.cpp (modified) (1 diff)
• html/HTMLOutputElement.cpp (modified) (1 diff)
• html/HTMLProgressElement.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-14  Ryosuke Niwa  <rniwa@webkit.org>
+
+        platform/mac/accessibility/progressbar.html fails on Mac WK1 and WK2
+        https://bugs.webkit.org/show_bug.cgi?id=106850
+
+        Reviewed by Chris Fleizach.
+
+        The bug was caused by some callers of supportsFocus directly calling that of Node.
+        Fixed the bug by calling HTMLElement's so that the virtual function on Element gets
+        called as needed.
+
+        * html/HTMLMeterElement.cpp:
+        (WebCore::HTMLMeterElement::supportsFocus):
+        * html/HTMLOutputElement.cpp:
+        (WebCore::HTMLOutputElement::supportsFocus):
+        * html/HTMLProgressElement.cpp:
+        (WebCore::HTMLProgressElement::supportsFocus):
+
 2013-01-14  Dima Gorbik  <dgorbik@apple.com>
 

trunk/Source/WebCore/html/HTMLMeterElement.cpp

@@ -75 +75 @@
 bool HTMLMeterElement::supportsFocus() const
 {
-    return Node::supportsFocus() && !disabled();
+    return HTMLElement::supportsFocus() && !disabled();
 }
 

trunk/Source/WebCore/html/HTMLOutputElement.cpp

@@ -59 +59 @@
 bool HTMLOutputElement::supportsFocus() const
 {
-    return Node::supportsFocus() && !disabled();
+    return HTMLElement::supportsFocus() && !disabled();
 }
 

trunk/Source/WebCore/html/HTMLProgressElement.cpp

@@ -91 +91 @@
 bool HTMLProgressElement::supportsFocus() const
 {
-    return Node::supportsFocus() && !disabled();
+    return HTMLElement::supportsFocus() && !disabled();
 }