Changeset 139756 in webkit

Timestamp:

Jan 15, 2013 10:49:17 AM (11 years ago)

Author:

arko@motorola.com

Message:

Microdata: propertiesCollection[name] should return undefined if item doesn't have a property named 'name'
​https://bugs.webkit.org/show_bug.cgi?id=106849

Reviewed by Kentaro Hara.

Source/WebCore:

We should return undefined if hasNamedItem() is false.

Test: fast/dom/MicroData/properties-collection-namedgetter-with-invalid-name.html

• bindings/v8/custom/V8HTMLCollectionCustom.cpp:

(WebCore::V8HTMLCollection::namedPropertyGetter):

LayoutTests:

• fast/dom/MicroData/properties-collection-namedgetter-with-invalid-name-expected.txt: Added.
• fast/dom/MicroData/properties-collection-namedgetter-with-invalid-name.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/dom/MicroData/properties-collection-namedgetter-with-invalid-name-expected.txt (added)
• LayoutTests/fast/dom/MicroData/properties-collection-namedgetter-with-invalid-name.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/bindings/v8/custom/V8HTMLCollectionCustom.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-01-15  Arko Saha  <arko@motorola.com>
+
+        Microdata: propertiesCollection[name] should return undefined if item doesn't have a property named 'name'
+        https://bugs.webkit.org/show_bug.cgi?id=106849
+
+        Reviewed by Kentaro Hara.
+
+        * fast/dom/MicroData/properties-collection-namedgetter-with-invalid-name-expected.txt: Added.
+        * fast/dom/MicroData/properties-collection-namedgetter-with-invalid-name.html: Added.
+
 2013-01-15  Emil A Eklund  <eae@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-15  Arko Saha  <arko@motorola.com>
+
+        Microdata: propertiesCollection[name] should return undefined if item doesn't have a property named 'name'
+        https://bugs.webkit.org/show_bug.cgi?id=106849
+
+        Reviewed by Kentaro Hara.
+
+        We should return undefined if hasNamedItem() is false.
+
+        Test: fast/dom/MicroData/properties-collection-namedgetter-with-invalid-name.html
+
+        * bindings/v8/custom/V8HTMLCollectionCustom.cpp:
+        (WebCore::V8HTMLCollection::namedPropertyGetter):
+
 2013-01-15  Michael Pruett  <michael@68k.org>
 

trunk/Source/WebCore/bindings/v8/custom/V8HTMLCollectionCustom.cpp

@@ -55 +55 @@
 #if ENABLE(MICRODATA)
     if (imp->type() == ItemProperties) {
+        if (!static_cast<HTMLPropertiesCollection*>(imp)->hasNamedItem(toWebCoreAtomicString(name)))
+            return v8Undefined();
         RefPtr<PropertyNodeList> item = static_cast<HTMLPropertiesCollection*>(imp)->propertyNodeList(toWebCoreAtomicString(name));
         if (!item)