Changeset 139772 in webkit
- Timestamp:
- Jan 15, 2013 12:39:40 PM (11 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r139770 r139772 1 2013-01-15 Ojan Vafai <ojan@chromium.org> 2 3 Cleanup visibility of some computePreferredLogicalWidths calls 4 https://bugs.webkit.org/show_bug.cgi?id=106933 5 6 Reviewed by Levi Weintraub. 7 8 No need for these to be public. 9 10 * rendering/RenderBox.h: 11 (WebCore::RenderBox::computePreferredLogicalWidths): 12 This should never get called in practice. Add an assert to that effect. 13 14 * rendering/RenderGrid.h: 15 (RenderGrid): 16 * rendering/RenderReplica.h: 17 (RenderReplica): 18 * rendering/RenderScrollbarPart.h: 19 (RenderScrollbarPart): 20 1 21 2013-01-13 Dirk Schulze <dschulze@adobe.com> 2 22 -
trunk/Source/WebCore/rendering/RenderBox.h
r139503 r139772 659 659 // These values are used in shrink-to-fit layout systems. 660 660 // These include tables, positioned objects, floats and flexible boxes. 661 virtual void computePreferredLogicalWidths() { setPreferredLogicalWidthsDirty(false); }661 virtual void computePreferredLogicalWidths() { ASSERT_NOT_REACHED(); setPreferredLogicalWidthsDirty(false); } 662 662 663 663 virtual LayoutRect frameRectForStickyPositioning() const OVERRIDE { return frameRect(); } -
trunk/Source/WebCore/rendering/RenderGrid.h
r139025 r139772 41 41 42 42 virtual void layoutBlock(bool relayoutChildren, LayoutUnit pageLogicalHeight = 0) OVERRIDE; 43 virtual void computePreferredLogicalWidths() OVERRIDE;44 43 45 44 virtual bool avoidsFloats() const OVERRIDE { return true; } … … 48 47 private: 49 48 virtual bool isRenderGrid() const OVERRIDE { return true; } 49 virtual void computePreferredLogicalWidths() OVERRIDE; 50 50 51 51 enum TrackSizingDirection { ForColumns, ForRows }; -
trunk/Source/WebCore/rendering/RenderReplica.h
r95901 r139772 44 44 45 45 virtual void layout(); 46 virtual void computePreferredLogicalWidths();47 46 48 47 virtual void paint(PaintInfo&, const LayoutPoint&); … … 50 49 private: 51 50 virtual bool isReplica() const { return true; } 51 virtual void computePreferredLogicalWidths(); 52 52 53 53 }; -
trunk/Source/WebCore/rendering/RenderScrollbarPart.h
r118076 r139772 44 44 45 45 virtual void layout(); 46 virtual void computePreferredLogicalWidths();47 46 48 47 void paintIntoRect(GraphicsContext*, const LayoutPoint&, const LayoutRect&); … … 63 62 64 63 private: 64 virtual void computePreferredLogicalWidths(); 65 65 66 void layoutHorizontalPart(); 66 67 void layoutVerticalPart();
Note: See TracChangeset
for help on using the changeset viewer.