Changeset 139772 in webkit


Ignore:
Timestamp:
Jan 15, 2013 12:39:40 PM (11 years ago)
Author:
ojan@chromium.org
Message:

Cleanup visibility of some computePreferredLogicalWidths calls
https://bugs.webkit.org/show_bug.cgi?id=106933

Reviewed by Levi Weintraub.

No need for these to be public.

  • rendering/RenderBox.h:

(WebCore::RenderBox::computePreferredLogicalWidths):
This should never get called in practice. Add an assert to that effect.

  • rendering/RenderGrid.h:

(RenderGrid):

  • rendering/RenderReplica.h:

(RenderReplica):

  • rendering/RenderScrollbarPart.h:

(RenderScrollbarPart):

Location:
trunk/Source/WebCore
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r139770 r139772  
     12013-01-15  Ojan Vafai  <ojan@chromium.org>
     2
     3        Cleanup visibility of some computePreferredLogicalWidths calls
     4        https://bugs.webkit.org/show_bug.cgi?id=106933
     5
     6        Reviewed by Levi Weintraub.
     7
     8        No need for these to be public.
     9
     10        * rendering/RenderBox.h:
     11        (WebCore::RenderBox::computePreferredLogicalWidths):
     12        This should never get called in practice. Add an assert to that effect.
     13
     14        * rendering/RenderGrid.h:
     15        (RenderGrid):
     16        * rendering/RenderReplica.h:
     17        (RenderReplica):
     18        * rendering/RenderScrollbarPart.h:
     19        (RenderScrollbarPart):
     20
    1212013-01-13  Dirk Schulze  <dschulze@adobe.com>
    222
  • trunk/Source/WebCore/rendering/RenderBox.h

    r139503 r139772  
    659659    // These values are used in shrink-to-fit layout systems.
    660660    // These include tables, positioned objects, floats and flexible boxes.
    661     virtual void computePreferredLogicalWidths() { setPreferredLogicalWidthsDirty(false); }
     661    virtual void computePreferredLogicalWidths() { ASSERT_NOT_REACHED(); setPreferredLogicalWidthsDirty(false); }
    662662
    663663    virtual LayoutRect frameRectForStickyPositioning() const OVERRIDE { return frameRect(); }
  • trunk/Source/WebCore/rendering/RenderGrid.h

    r139025 r139772  
    4141
    4242    virtual void layoutBlock(bool relayoutChildren, LayoutUnit pageLogicalHeight = 0) OVERRIDE;
    43     virtual void computePreferredLogicalWidths() OVERRIDE;
    4443
    4544    virtual bool avoidsFloats() const OVERRIDE { return true; }
     
    4847private:
    4948    virtual bool isRenderGrid() const OVERRIDE { return true; }
     49    virtual void computePreferredLogicalWidths() OVERRIDE;
    5050
    5151    enum TrackSizingDirection { ForColumns, ForRows };
  • trunk/Source/WebCore/rendering/RenderReplica.h

    r95901 r139772  
    4444
    4545    virtual void layout();
    46     virtual void computePreferredLogicalWidths();
    4746   
    4847    virtual void paint(PaintInfo&, const LayoutPoint&);
     
    5049private:
    5150    virtual bool isReplica() const { return true; }
     51    virtual void computePreferredLogicalWidths();
    5252
    5353};
  • trunk/Source/WebCore/rendering/RenderScrollbarPart.h

    r118076 r139772  
    4444
    4545    virtual void layout();
    46     virtual void computePreferredLogicalWidths();
    4746   
    4847    void paintIntoRect(GraphicsContext*, const LayoutPoint&, const LayoutRect&);
     
    6362
    6463private:
     64    virtual void computePreferredLogicalWidths();
     65
    6566    void layoutHorizontalPart();
    6667    void layoutVerticalPart();
Note: See TracChangeset for help on using the changeset viewer.