Changeset 139775 in webkit


Ignore:
Timestamp:
Jan 15, 2013 12:47:18 PM (11 years ago)
Author:
tommyw@google.com
Message:

MediaStream API: Rename the [add|remove]Track callbacks to [add|remove]RemoteTrack for clarity
https://bugs.webkit.org/show_bug.cgi?id=106791

Reviewed by Adam Barth.

No tests needed.

  • Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::addRemoteTrack):
(WebCore::MediaStream::removeRemoteTrack):

  • Modules/mediastream/MediaStream.h:
  • platform/mediastream/MediaStreamCenter.cpp:

(WebCore::MediaStreamCenter::addMediaStreamTrack):
(WebCore::MediaStreamCenter::removeMediaStreamTrack):

  • platform/mediastream/MediaStreamDescriptor.h:

(MediaStreamDescriptorClient):

Location:
trunk/Source/WebCore
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r139774 r139775  
     12013-01-15  Tommy Widenflycht  <tommyw@google.com>
     2
     3        MediaStream API: Rename the [add|remove]Track callbacks to [add|remove]RemoteTrack for clarity
     4        https://bugs.webkit.org/show_bug.cgi?id=106791
     5
     6        Reviewed by Adam Barth.
     7
     8        No tests needed.
     9
     10        * Modules/mediastream/MediaStream.cpp:
     11        (WebCore::MediaStream::addRemoteTrack):
     12        (WebCore::MediaStream::removeRemoteTrack):
     13        * Modules/mediastream/MediaStream.h:
     14        * platform/mediastream/MediaStreamCenter.cpp:
     15        (WebCore::MediaStreamCenter::addMediaStreamTrack):
     16        (WebCore::MediaStreamCenter::removeMediaStreamTrack):
     17        * platform/mediastream/MediaStreamDescriptor.h:
     18        (MediaStreamDescriptorClient):
     19
    1202013-01-15  Mark Pilgrim  <pilgrim@chromium.org>
    221
  • trunk/Source/WebCore/Modules/mediastream/MediaStream.cpp

    r139732 r139775  
    256256}
    257257
    258 void MediaStream::addTrack(MediaStreamComponent* component)
     258void MediaStream::addRemoteTrack(MediaStreamComponent* component)
    259259{
    260260    if (ended())
     
    274274}
    275275
    276 void MediaStream::removeTrack(MediaStreamComponent* component)
     276void MediaStream::removeRemoteTrack(MediaStreamComponent* component)
    277277{
    278278    if (ended())
  • trunk/Source/WebCore/Modules/mediastream/MediaStream.h

    r139611 r139775  
    9696
    9797    // MediaStreamDescriptorClient
    98     virtual void addTrack(MediaStreamComponent*) OVERRIDE;
    99     virtual void removeTrack(MediaStreamComponent*) OVERRIDE;
     98    virtual void addRemoteTrack(MediaStreamComponent*) OVERRIDE;
     99    virtual void removeRemoteTrack(MediaStreamComponent*) OVERRIDE;
    100100
    101101    void scheduleDispatchEvent(PassRefPtr<Event>);
  • trunk/Source/WebCore/platform/mediastream/MediaStreamCenter.cpp

    r131914 r139775  
    6161    MediaStreamDescriptorClient* client = streamDescriptor->client();
    6262    if (client)
    63         client->addTrack(component);
     63        client->addRemoteTrack(component);
    6464}
    6565
     
    6868    MediaStreamDescriptorClient* client = streamDescriptor->client();
    6969    if (client)
    70         client->removeTrack(component);
     70        client->removeRemoteTrack(component);
    7171}
    7272
  • trunk/Source/WebCore/platform/mediastream/MediaStreamDescriptor.h

    r139611 r139775  
    4646
    4747    virtual void streamEnded() = 0;
    48     virtual void addTrack(MediaStreamComponent*) = 0;
    49     virtual void removeTrack(MediaStreamComponent*) = 0;
     48    virtual void addRemoteTrack(MediaStreamComponent*) = 0;
     49    virtual void removeRemoteTrack(MediaStreamComponent*) = 0;
    5050};
    5151
Note: See TracChangeset for help on using the changeset viewer.