Changeset 139778 in webkit
- Timestamp:
- Jan 15, 2013 1:04:09 PM (11 years ago)
- Location:
- trunk/Tools
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Tools/ChangeLog
r139776 r139778 1 2013-01-15 Dirk Pranke <dpranke@chromium.org> 2 3 nrwt: change the default # of locked shards on chromium_win to 1 4 https://bugs.webkit.org/show_bug.cgi?id=106938 5 6 Reviewed by Eric Seidel. 7 8 It looks like LigHTTPd might be buggy or unstable if we are 9 running multiple http tests in parallel; see 10 http://code.google.com/p/chromium/issues/detail?id=169530 for more 11 context as well. This change will stop running http tests in parallel 12 and we can see if this fixes things. 13 14 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 15 (ChromiumWinPort.default_max_locked_shards): 16 * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: 17 (ChromiumWinTest.test_path_to_image_diff): 18 (ChromiumWinTest): 19 (ChromiumWinTest.test_default_max_locked_shards): 20 1 21 2013-01-15 Jochen Eisinger <jochen@chromium.org> 2 22 -
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_win.py
r136545 r139778 116 116 return path.replace('\\', '/') 117 117 118 def default_max_locked_shards(self): 119 # FIXME: lighttpd may be unstable with > 1 concurrent shards. See 120 # http://code.google.com/p/chromium/issues/detail?id=169530 121 return 1 122 118 123 # 119 124 # PROTECTED ROUTINES -
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py
r139560 r139778 132 132 def test_path_to_image_diff(self): 133 133 self.assertEqual(self.make_port()._path_to_image_diff(), '/mock-checkout/out/Release/ImageDiff.exe') 134 135 def test_default_max_locked_shards(self): 136 # FIXME: Remove this test when we remove the override for default_max_locked_shards() in chromium_win.py 137 port = self.make_port() 138 port.default_child_processes = lambda: 16 139 self.assertEqual(port.default_max_locked_shards(), 1) 140 port.default_child_processes = lambda: 2 141 self.assertEqual(port.default_max_locked_shards(), 1)
Note: See TracChangeset
for help on using the changeset viewer.