Changeset 139801 in webkit

Timestamp:

Jan 15, 2013 3:45:14 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Crash when saving history with no items in it.
​https://bugs.webkit.org/show_bug.cgi?id=104261

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-01-15
Reviewed by Darin Adler.

• WebHistory.cpp:

(WebHistory::saveHistoryGuts): Added null pointer check

Location:

trunk/Source/WebKit/win

Files:

• ChangeLog (modified) (1 diff)
• WebHistory.cpp (modified) (1 diff)

trunk/Source/WebKit/win/ChangeLog

@@ +1 @@
+2013-01-15  peavo@outlook.com  <peavo@outlook.com>
+
+        Crash when saving history with no items in it.
+        https://bugs.webkit.org/show_bug.cgi?id=104261
+
+        Reviewed by Darin Adler.
+
+        * WebHistory.cpp:
+        (WebHistory::saveHistoryGuts): Added null pointer check
+
 2013-01-09  Levi Weintraub <leviw@chromium.org>
 

trunk/Source/WebKit/win/WebHistory.cpp

@@ -382 +382 @@
     RetainPtr<CFDataRef> data = this->data();
 
+    if (!data.get())
+        return E_FAIL;
+
     RetainPtr<CFWriteStreamRef> stream(AdoptCF, CFWriteStreamCreateWithFile(kCFAllocatorDefault, url));
     if (!stream)