Changeset 139807 in webkit


Ignore:
Timestamp:
Jan 15, 2013 4:14:57 PM (11 years ago)
Author:
eae@chromium.org
Message:

[Sub pixel layout] RTL cells with padding wraps
https://bugs.webkit.org/show_bug.cgi?id=106843

Source/WebCore:

Reviewed by Levi Weintraub.

At certain zoom levels table cells with padding wraps for rtl
content.

Test: fast/sub-pixel/table-rtl-padding.html

  • rendering/RenderTable.h: Override paddingStart/End to return

integer values for padding as we do elsewhere in the table code.

LayoutTests:

Reviewed by Levi Weintraub.

Add test for rtl tables with padding.

  • fast/sub-pixel/input-caret-on-subpixel-bound-expected.html:
  • fast/sub-pixel/table-rtl-padding-expected.html: Added.
  • fast/sub-pixel/table-rtl-padding.html: Added.
Location:
trunk
Files:
2 added
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r139806 r139807  
     12013-01-15  Emil A Eklund  <eae@chromium.org>
     2
     3        [Sub pixel layout] RTL cells with padding wraps
     4        https://bugs.webkit.org/show_bug.cgi?id=106843
     5
     6        Reviewed by Levi Weintraub.
     7       
     8        Add test for rtl tables with padding.
     9
     10        * fast/sub-pixel/input-caret-on-subpixel-bound-expected.html:
     11        * fast/sub-pixel/table-rtl-padding-expected.html: Added.
     12        * fast/sub-pixel/table-rtl-padding.html: Added.
     13
    1142013-01-15  Dominic Mazzoni  <dmazzoni@google.com>
    215
  • trunk/LayoutTests/fast/sub-pixel/input-caret-on-subpixel-bound-expected.html

    r137529 r139807  
    1111      }
    1212      input {
    13           padding: 6px 5px 5px 6px;
     13          padding: 6px 6px 5px 5px;
    1414      }
    1515    </style>
  • trunk/Source/WebCore/ChangeLog

    r139806 r139807  
     12013-01-15  Emil A Eklund  <eae@chromium.org>
     2
     3        [Sub pixel layout] RTL cells with padding wraps
     4        https://bugs.webkit.org/show_bug.cgi?id=106843
     5
     6        Reviewed by Levi Weintraub.
     7       
     8        At certain zoom levels table cells with padding wraps for rtl
     9        content.
     10
     11        Test: fast/sub-pixel/table-rtl-padding.html
     12
     13        * rendering/RenderTable.h: Override paddingStart/End to return
     14        integer values for padding as we do elsewhere in the table code.
     15
    1162013-01-15  Dominic Mazzoni  <dmazzoni@google.com>
    217
  • trunk/Source/WebCore/rendering/RenderTable.h

    r135891 r139807  
    195195    }
    196196
     197    // Override paddingStart/End to return pixel values to match behavor of RenderTableCell.
     198    virtual LayoutUnit paddingEnd() const OVERRIDE { return static_cast<int>(RenderBlock::paddingEnd()); }
     199    virtual LayoutUnit paddingStart() const OVERRIDE { return static_cast<int>(RenderBlock::paddingStart()); }
     200
    197201    LayoutUnit bordersPaddingAndSpacingInRowDirection() const
    198202    {
Note: See TracChangeset for help on using the changeset viewer.