Changeset 139827 in webkit


Ignore:
Timestamp:
Jan 15, 2013 7:44:37 PM (11 years ago)
Author:
dpranke@chromium.org
Message:

webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer.test_win32_start_and_stop is flaky
https://bugs.webkit.org/show_bug.cgi?id=106974

Reviewed by Ryosuke Niwa.

I forgot to stub out the call to check to ensure that the ports were
available, so this test could fail if something was listening on 8000 or
8443 on the machine.

  • Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:

(TestHttpServer.test_win32_start_and_stop):

Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r139821 r139827  
     12013-01-15  Dirk Pranke  <dpranke@chromium.org>
     2
     3        webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer.test_win32_start_and_stop is flaky
     4        https://bugs.webkit.org/show_bug.cgi?id=106974
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        I forgot to stub out the call to check to ensure that the ports were
     9        available, so this test could fail if something was listening on 8000 or
     10        8443 on the machine.
     11
     12        * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
     13        (TestHttpServer.test_win32_start_and_stop):
     14
    1152013-01-15  Levi Weintraub  <leviw@chromium.org>
    216
  • trunk/Tools/Scripts/webkitpy/layout_tests/servers/http_server_unittest.py

    r139764 r139827  
    7979                              "/mock/one-additional-dir": "/mock-checkout/one-additional-dir",
    8080                              "/mock/another-additional-dir": "/mock-checkout/one-additional-dir"})
     81        server._check_that_all_ports_are_available = lambda: True
    8182        server._is_server_running_on_all_ports = lambda: True
    8283
Note: See TracChangeset for help on using the changeset viewer.