Changeset 139828 in webkit
- Timestamp:
- Jan 15, 2013 7:53:35 PM (11 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r139824 r139828 1 2013-01-15 Charles Wei <charles.wei@torchmobile.com.cn> 2 3 [BlackBerry] LayerRenderingResults doesn't need to maintain the hole punch rect 4 https://bugs.webkit.org/show_bug.cgi?id=106896 5 6 Reviewed by George Staikos. 7 Internally reviewed by Arvid Nilsson and John Griggs. 8 9 No new tests,clean up code which is not used anymore. 10 11 * platform/graphics/blackberry/LayerRenderer.cpp: 12 (WebCore::LayerRenderer::drawHolePunchRect): 13 * platform/graphics/blackberry/LayerRenderer.h: 14 (LayerRenderingResults): 15 1 16 2013-01-15 Charles Wei <charles.wei@torchmobile.com.cn> 2 17 -
trunk/Source/WebCore/platform/graphics/blackberry/LayerRenderer.cpp
r138056 r139828 613 613 checkGLError(); 614 614 glBlendFunc(GL_ONE, GL_ONE_MINUS_SRC_ALPHA); 615 616 IntRect holeWC = toWebKitWindowCoordinates(hole.boundingBox());617 m_lastRenderingResults.addHolePunchRect(holeWC);618 615 } 619 616 … … 1199 1196 } 1200 1197 1201 IntRect LayerRenderingResults::holePunchRect(unsigned index) const1202 {1203 if (index >= m_holePunchRects.size())1204 return IntRect();1205 1206 return m_holePunchRects.at(index);1207 }1208 1209 void LayerRenderingResults::addHolePunchRect(const IntRect& rect)1210 {1211 #if DEBUG_CLIPPING1212 printf("LayerRenderingResults::addHolePunchRect (%d,%d %dx%d)\n", rect.x(), rect.y(), rect.width(), rect.height());1213 fflush(stdout);1214 #endif1215 if (!rect.isEmpty())1216 m_holePunchRects.append(rect);1217 }1218 1219 1198 void LayerRenderingResults::addDirtyRect(const IntRect& rect) 1220 1199 { -
trunk/Source/WebCore/platform/graphics/blackberry/LayerRenderer.h
r132219 r139828 57 57 LayerRenderingResults() : wasEmpty(true), needsAnimationFrame(false) { } 58 58 59 void addHolePunchRect(const IntRect&);60 IntRect holePunchRect(size_t index) const;61 size_t holePunchRectSize() { return m_holePunchRects.size(); }62 63 59 static const int NumberOfDirtyRects = 3; 64 60 const IntRect& dirtyRect(int i) const { return m_dirtyRects[i]; } … … 73 69 74 70 private: 75 Vector<IntRect> m_holePunchRects; // Rects are in compositing surface coordinates.76 71 IntRect m_dirtyRects[NumberOfDirtyRects]; 77 72 };
Note: See TracChangeset
for help on using the changeset viewer.