Changeset 139828 in webkit


Ignore:
Timestamp:
Jan 15, 2013 7:53:35 PM (11 years ago)
Author:
charles.wei@torchmobile.com.cn
Message:

[BlackBerry] LayerRenderingResults doesn't need to maintain the hole punch rect
https://bugs.webkit.org/show_bug.cgi?id=106896

Reviewed by George Staikos.
Internally reviewed by Arvid Nilsson and John Griggs.

No new tests,clean up code which is not used anymore.

  • platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore::LayerRenderer::drawHolePunchRect):

  • platform/graphics/blackberry/LayerRenderer.h:

(LayerRenderingResults):

Location:
trunk/Source/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r139824 r139828  
     12013-01-15  Charles Wei  <charles.wei@torchmobile.com.cn>
     2
     3        [BlackBerry]  LayerRenderingResults doesn't need to maintain the hole punch rect
     4        https://bugs.webkit.org/show_bug.cgi?id=106896
     5
     6        Reviewed by George Staikos.
     7        Internally reviewed by Arvid Nilsson and John Griggs.
     8
     9        No new tests,clean up code which is not used anymore.
     10
     11        * platform/graphics/blackberry/LayerRenderer.cpp:
     12        (WebCore::LayerRenderer::drawHolePunchRect):
     13        * platform/graphics/blackberry/LayerRenderer.h:
     14        (LayerRenderingResults):
     15
    1162013-01-15  Charles Wei  <charles.wei@torchmobile.com.cn>
    217
  • trunk/Source/WebCore/platform/graphics/blackberry/LayerRenderer.cpp

    r138056 r139828  
    613613    checkGLError();
    614614    glBlendFunc(GL_ONE, GL_ONE_MINUS_SRC_ALPHA);
    615 
    616     IntRect holeWC = toWebKitWindowCoordinates(hole.boundingBox());
    617     m_lastRenderingResults.addHolePunchRect(holeWC);
    618615}
    619616
     
    11991196}
    12001197
    1201 IntRect LayerRenderingResults::holePunchRect(unsigned index) const
    1202 {
    1203     if (index >= m_holePunchRects.size())
    1204         return IntRect();
    1205 
    1206     return m_holePunchRects.at(index);
    1207 }
    1208 
    1209 void LayerRenderingResults::addHolePunchRect(const IntRect& rect)
    1210 {
    1211 #if DEBUG_CLIPPING
    1212     printf("LayerRenderingResults::addHolePunchRect (%d,%d %dx%d)\n", rect.x(), rect.y(), rect.width(), rect.height());
    1213     fflush(stdout);
    1214 #endif
    1215     if (!rect.isEmpty())
    1216         m_holePunchRects.append(rect);
    1217 }
    1218 
    12191198void LayerRenderingResults::addDirtyRect(const IntRect& rect)
    12201199{
  • trunk/Source/WebCore/platform/graphics/blackberry/LayerRenderer.h

    r132219 r139828  
    5757    LayerRenderingResults() : wasEmpty(true), needsAnimationFrame(false) { }
    5858
    59     void addHolePunchRect(const IntRect&);
    60     IntRect holePunchRect(size_t index) const;
    61     size_t holePunchRectSize() { return m_holePunchRects.size(); }
    62 
    6359    static const int NumberOfDirtyRects = 3;
    6460    const IntRect& dirtyRect(int i) const { return m_dirtyRects[i]; }
     
    7369
    7470private:
    75     Vector<IntRect> m_holePunchRects; // Rects are in compositing surface coordinates.
    7671    IntRect m_dirtyRects[NumberOfDirtyRects];
    7772};
Note: See TracChangeset for help on using the changeset viewer.