Changeset 139830 in webkit

Timestamp:

Jan 15, 2013 8:42:47 PM (11 years ago)

Author:

dpranke@chromium.org

Message:

remove extraneous output in test-webkitpy
​https://bugs.webkit.org/show_bug.cgi?id=106971

Reviewed by Ojan Vafai.

We weren't ignoring or capturing the echoed output from
these two tests, and getting noise in the logs as a result.

• Scripts/webkitpy/common/system/executive_unittest.py:

(ExecutiveTest.test_auto_stringify_args):
(ExecutiveTest.test_popen_args):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/common/system/executive_unittest.py (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2013-01-15  Dirk Pranke  <dpranke@chromium.org>
+
+        remove extraneous output in test-webkitpy
+        https://bugs.webkit.org/show_bug.cgi?id=106971
+
+        Reviewed by Ojan Vafai.
+
+        We weren't ignoring or capturing the echoed output from
+        these two tests, and getting noise in the logs as a result.
+
+        * Scripts/webkitpy/common/system/executive_unittest.py:
+        (ExecutiveTest.test_auto_stringify_args):
+        (ExecutiveTest.test_popen_args):
+
 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
 

trunk/Tools/Scripts/webkitpy/common/system/executive_unittest.py

@@ -117 +117 @@
         executive = Executive()
         executive.run_command(command_line('echo', 1))
-        executive.popen(command_line('echo', 1)).wait()
+        executive.popen(command_line('echo', 1), stdout=executive.PIPE).wait()
         self.assertEqual('echo 1', executive.command_for_printing(['echo', 1]))
 
@@ -123 +123 @@
         executive = Executive()
         # Explicitly naming the 'args' argument should not thow an exception.
-        executive.popen(args=command_line('echo', 1)).wait()
+        executive.popen(args=command_line('echo', 1), stdout=executive.PIPE).wait()
 
     def test_run_command_with_unicode(self):