Changeset 139848 in webkit

Timestamp:

Jan 16, 2013 1:24:26 AM (11 years ago)

Author:

aandrey@chromium.org

Message:

Web Inspector: array grouping does not work for big and negative number keys
​https://bugs.webkit.org/show_bug.cgi?id=106891

Reviewed by Pavel Feldman.

Source/WebCore:

Fixing array grouping for arrays that contain big or negative number representations as object keys.

• inspector/front-end/ObjectPropertiesSection.js:

(.buildObjectFragment):

LayoutTests:

• inspector/console/console-big-array-expected.txt:
• inspector/console/console-big-array.html:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/inspector/console/console-big-array-expected.txt (modified) (2 diffs)
• LayoutTests/inspector/console/console-big-array.html (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/inspector/front-end/ObjectPropertiesSection.js (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-01-16  Andrey Adaikin  <aandrey@chromium.org>
+
+        Web Inspector: array grouping does not work for big and negative number keys
+        https://bugs.webkit.org/show_bug.cgi?id=106891
+
+        Reviewed by Pavel Feldman.
+
+        * inspector/console/console-big-array-expected.txt:
+        * inspector/console/console-big-array.html:
+
 2013-01-16  Dominic Cooney   <dominicc@chromium.org>
 

trunk/LayoutTests/inspector/console/console-big-array-expected.txt

@@ -3 +3 @@
 CONSOLE MESSAGE: line 24: 0,1,2,3,4,5,6,7,8,9,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,100
 CONSOLE MESSAGE: line 29: 0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31,32,33,34,35,36,37,38,39,40,41,42,43,44,45,46,47,48,49,50,51,52,53,54,55,56,57,58,59,60,61,62,63,64,65,66,67,68,69,70,71,72,73,74,75,76,77,78,79,80,81,82,83,84,85,86,87,88,89,90,91,92,93,94,95,96,97,98,99,100,101,102,103,104,105,106,107,108,109,110,111,112,113,114,115,116,117,118,119,120,121,122,123,124,125,126,127,128,129,130,131,132,133,134,135,136,137,138,139,140,141,142,143,144,145,146,147,148,149,150,151,152,153,154,155,156,157,158,159,160,161,162,163,164,165,166,167,168,169,170,171,172,173,174,175,176,177,178,179,180,181,182,183,184,185,186,187,188,189,190,191,192,193,194,195,196,197,198,199,200,201,202,203,204,205,206,207,208,209,210,211,212,213,214,215,216,217,218,219,220,221,222,223,224,225,226,227,228,229,230,231,232,233,234,235,236,237,238,239,240,241,242,243,244,245,246,247,248,249,250,251,252,253,254,255,256,257,258,259,260,261,262,263,264,265,266,267,268,269,270,271,272,273,274,275,276,277,278,279,280,281,282,283,284,285,286,287,288,289,290,291,292,293,294,295,296,297,298,299,300,301,302,303,304,305,306,307,308,309,310,311,312,313,314,315,316,317,318,319,320,321,322,323,324,325,326,327,328,329,330,331,332,333,334,335,336,337,338,339,340,341,342,343,344,345,346,347,348,349,350,351,352,353,354,355,356,357,358,359,360,361,362,363,364,365,366,367,368,369,370,371,372,373,374,375,376,377,378,379,380,381,382,383,384,385,386,387,388,389,390,391,392,393,394,395,396,397,398,399,400,401,402,403,404
+CONSOLE MESSAGE: line 38: 0,1,2,3,4,5,6,7,8,9,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,123
 Tests that console logging dumps large arrays properly.
 
@@ -117 +118 @@
     __proto__: Array[0] console-big-array.html:29
 
+Array[124]
+    0: 0
+    1: 1
+    2: 2
+    3: 3
+    4: 4
+    5: 5
+    6: 6
+    7: 7
+    8: 8
+    9: 9
+    123: 123
+    4294967295: 4294967295
+    4294967296: 4294967296
+    -123: -123
+    length: 124
+    __proto__: Array[0] console-big-array.html:38
+

trunk/LayoutTests/inspector/console/console-big-array.html

@@ -28 +28 @@
       d[i] = i;
     console.dir(d);
+
+    var e = [];
+    for (var i = 0; i < 10; ++i)
+        e[i] = i;
+    e[123] = 123;
+    e[-123] = -123;
+    e[4294967295] = 4294967295;
+    e[4294967296] = 4294967296;
+    console.dir(e);
 
     runTest();

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-16  Andrey Adaikin  <aandrey@chromium.org>
+
+        Web Inspector: array grouping does not work for big and negative number keys
+        https://bugs.webkit.org/show_bug.cgi?id=106891
+
+        Reviewed by Pavel Feldman.
+
+        Fixing array grouping for arrays that contain big or negative number representations as object keys.
+
+        * inspector/front-end/ObjectPropertiesSection.js:
+        (.buildObjectFragment):
+
 2013-01-16  Andrey Lushnikov  <lushnikov@chromium.org>
 

trunk/Source/WebCore/inspector/front-end/ObjectPropertiesSection.js

@@ -763 +763 @@
         for (var i = 0; i < names.length; ++i) {
             var name = names[i];
-            if (!isNaN(name))
+            if (!isNaN(name) && 0 <= name && name < this.length)
                 continue;
             var descriptor = Object.getOwnPropertyDescriptor(this, name);