Changeset 139862 in webkit

Timestamp:

Jan 16, 2013 2:43:52 AM (11 years ago)

Author:

vsevik@chromium.org

Message:

Web Inspector: Store project UISourceCodes in a map with uri as a key for faster lookup.
​https://bugs.webkit.org/show_bug.cgi?id=106911

Reviewed by Pavel Feldman.

• inspector/front-end/Workspace.js:

(WebInspector.Project):
(WebInspector.Project.prototype._fileAdded):
(WebInspector.Project.prototype._fileRemoved):
(WebInspector.Project.prototype._reset):
(WebInspector.Project.prototype.uiSourceCodeForOriginURL):
(WebInspector.Project.prototype.uiSourceCodeForURI):
(WebInspector.Project.prototype.uiSourceCodes):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/Workspace.js (modified) (7 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-15  Vsevolod Vlasov  <vsevik@chromium.org>
+
+        Web Inspector: Store project UISourceCodes in a map with uri as a key for faster lookup.
+        https://bugs.webkit.org/show_bug.cgi?id=106911
+
+        Reviewed by Pavel Feldman.
+
+        * inspector/front-end/Workspace.js:
+        (WebInspector.Project):
+        (WebInspector.Project.prototype._fileAdded):
+        (WebInspector.Project.prototype._fileRemoved):
+        (WebInspector.Project.prototype._reset):
+        (WebInspector.Project.prototype.uiSourceCodeForOriginURL):
+        (WebInspector.Project.prototype.uiSourceCodeForURI):
+        (WebInspector.Project.prototype.uiSourceCodes):
+
 2013-01-15  Vsevolod Vlasov  <vsevik@chromium.org>
 

trunk/Source/WebCore/inspector/front-end/Workspace.js

@@ -132 +132 @@
 {
     this._name = name;
-    this._uiSourceCodes = [];
+    /** @type {Object.<string, WebInspector.UISourceCode>} */
+    this._uiSourceCodesForURI = {};
     this._workspace = workspace;
     this._workspaceProvider = workspaceProvider;
@@ -168 +169 @@
         uiSourceCode.isContentScript = fileDescriptor.isContentScript;
         uiSourceCode.isSnippet = fileDescriptor.isSnippet;
-        this._uiSourceCodes.push(uiSourceCode);
+        this._uiSourceCodesForURI[uiSourceCode.uri()] = uiSourceCode;
         this._workspace.dispatchEventToListeners(WebInspector.UISourceCodeProvider.Events.UISourceCodeAdded, uiSourceCode);
     },
@@ -178 +179 @@
         if (!uiSourceCode)
             return;
-        this._uiSourceCodes.splice(this._uiSourceCodes.indexOf(uiSourceCode), 1);
+        delete this._uiSourceCodesForURI[uiSourceCode.uri()];
         this._workspace.dispatchEventToListeners(WebInspector.UISourceCodeProvider.Events.UISourceCodeRemoved, uiSourceCode);
     },
@@ -185 +186 @@
     {
         this._workspace.dispatchEventToListeners(WebInspector.Workspace.Events.ProjectWillReset, this);
-        this._uiSourceCodes = [];
+        this._uiSourceCodesForURI = {};
     },
 
@@ -194 +195 @@
     uiSourceCodeForOriginURL: function(originURL)
     {
-        for (var i = 0; i < this._uiSourceCodes.length; ++i) {
-            if (this._uiSourceCodes[i].originURL() === originURL)
-                return this._uiSourceCodes[i];
+        for (var uri in this._uiSourceCodesForURI) {
+            var uiSourceCode = this._uiSourceCodesForURI[uri];
+            if (uiSourceCode.originURL() === originURL)
+                return uiSourceCode;
         }
         return null;
@@ -207 +209 @@
     uiSourceCodeForURI: function(uri)
     {
-        for (var i = 0; i < this._uiSourceCodes.length; ++i) {
-            if (this._uiSourceCodes[i].uri() === uri)
-                return this._uiSourceCodes[i];
-        }
-        return null;
+        return this._uiSourceCodesForURI[uri];
     },
 
@@ -219 +217 @@
     uiSourceCodes: function()
     {
-        return this._uiSourceCodes;
+        return Object.values(this._uiSourceCodesForURI);
     },