Changeset 139883 in webkit

Timestamp:

Jan 16, 2013 8:00:38 AM (11 years ago)

Author:

caseq@chromium.org

Message:

Web Inspector: cookies with empty value are parsed incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=107012

Reviewed by Pavel Feldman.

Source/WebCore:

Require cookie value to be a string, not a non-empty string, before
employing legacy compatibility hack of treating bare token as value
for the cookie with an empty name.

• inspector/front-end/CookieParser.js:

(WebInspector.CookieParser.prototype._addCookie):

LayoutTests:

• inspector/cookie-parser-expected.txt:
• inspector/cookie-parser.html:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/inspector/cookie-parser-expected.txt (modified) (1 diff)
• LayoutTests/inspector/cookie-parser.html (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/inspector/front-end/CookieParser.js (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-01-16  Andrey Kosyakov  <caseq@chromium.org>
+
+        Web Inspector: cookies with empty value are parsed incorrectly
+        https://bugs.webkit.org/show_bug.cgi?id=107012
+
+        Reviewed by Pavel Feldman.
+
+        * inspector/cookie-parser-expected.txt:
+        * inspector/cookie-parser.html:
+
 2013-01-16  Andrey Lushnikov  <lushnikov@chromium.org>
 

trunk/LayoutTests/inspector/cookie-parser-expected.txt

@@ -131 +131 @@
     secure : undefined
 }
+source: cooke1; Path=/; Domain=.example.com;
+name: , value: cooke1, httpOnly: false, secure: false, session: true, path: /, domain: .example.com, port: undefined, expires: n/a, size: 36
+{
+    domain : ".example.com"
+    path : "/"
+}
+source: cooke1=; Path=/; Domain=.example.com;
+name: cooke1, value: , httpOnly: false, secure: false, session: true, path: /, domain: .example.com, port: undefined, expires: n/a, size: 37
+{
+    domain : ".example.com"
+    path : "/"
+}
 

trunk/LayoutTests/inspector/cookie-parser.html

@@ -61 +61 @@
     InspectorTest.parseAndDumpSetCookie("cooke1 = value; expires = Mon, Oct 18 2010 17:00 GMT+0000; Domain   =.example.com\nCookie2 = value2; Path = /foo; DOMAIN = foo.example.com; HttpOnly; Secure; Discard;");
     InspectorTest.parseAndDumpSetCookie("cooke1 = value; max-age= 1440; Domain   =.example.com\n Cookie2 = value2; Path = /foo; DOMAIN = foo.example.com; HttpOnly; Secure; Discard;");
+    InspectorTest.parseAndDumpSetCookie("cooke1; Path=/; Domain=.example.com;");
+    InspectorTest.parseAndDumpSetCookie("cooke1=; Path=/; Domain=.example.com;");
     InspectorTest.completeTest();
 }

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-16  Andrey Kosyakov  <caseq@chromium.org>
+
+        Web Inspector: cookies with empty value are parsed incorrectly
+        https://bugs.webkit.org/show_bug.cgi?id=107012
+
+        Reviewed by Pavel Feldman.
+
+        Require cookie value to be a string, not a non-empty string, before
+        employing legacy compatibility hack of treating bare token as value
+        for the cookie with an empty name.
+
+        * inspector/front-end/CookieParser.js:
+        (WebInspector.CookieParser.prototype._addCookie):
+
 2013-01-16  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
 

trunk/Source/WebCore/inspector/front-end/CookieParser.js

@@ -172 +172 @@
         // Mozilla bug 169091: Mozilla, IE and Chrome treat single token (w/o "=") as
         // specifying a value for a cookie with empty name.
-        this._lastCookie = keyValue.value ? new WebInspector.Cookie(keyValue.key, keyValue.value, type) :
+        this._lastCookie = typeof keyValue.value === "string" ? new WebInspector.Cookie(keyValue.key, keyValue.value, type) :
             new WebInspector.Cookie("", keyValue.key, type);
         this._lastCookiePosition = keyValue.position;