Changeset 139922 in webkit

Timestamp:

Jan 16, 2013 1:58:45 PM (11 years ago)

Author:

alexis@webkit.org

Message:

Monitor usage of unprefixed and prefixed DOM events for CSS Transitions.
​https://bugs.webkit.org/show_bug.cgi?id=107004

Reviewed by Adam Barth.

Monitor the usage of transitionEnd events as well as
webkitTransitionEnd events so we can know in the future how much the
prefixed version is used to remove it becomes irrelevant.

No new tests : no behavior changes, we're just adding monitoring.

• dom/EventTarget.cpp:

(WebCore):
(WebCore::EventTarget::fireEventListeners):

• page/FeatureObserver.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/EventTarget.cpp (modified) (1 diff)
• page/FeatureObserver.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-16  Alexis Menard  <alexis@webkit.org>
+
+        Monitor usage of unprefixed and prefixed DOM events for CSS Transitions.
+        https://bugs.webkit.org/show_bug.cgi?id=107004
+
+        Reviewed by Adam Barth.
+
+        Monitor the usage of transitionEnd events as well as
+        webkitTransitionEnd events so we can know in the future how much the
+        prefixed version is used to remove it becomes irrelevant.
+
+        No new tests : no behavior changes, we're just adding monitoring.
+
+        * dom/EventTarget.cpp:
+        (WebCore):
+        (WebCore::EventTarget::fireEventListeners):
+        * page/FeatureObserver.h:
+
 2013-01-16  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebCore/dom/EventTarget.cpp

@@ -204 +204 @@
     else if (listenerPrefixedVector)
         fireEventListeners(createMatchingPrefixedEvent(event).get(), d, *listenerPrefixedVector);
-    
+
+    if (!prefixedTypeName.isEmpty()) {
+        ScriptExecutionContext* context = scriptExecutionContext();
+        if (context && context->isDocument()) {
+            Document* document = static_cast<Document*>(context);
+            if (document->domWindow()) {
+                if (listenerPrefixedVector)
+                    if (listenerUnprefixedVector)
+                        FeatureObserver::observe(document->domWindow(), FeatureObserver::PrefixedAndUnprefixedTransitionEndEvent);
+                    else
+                        FeatureObserver::observe(document->domWindow(), FeatureObserver::PrefixedTransitionEndEvent);
+                else if (listenerUnprefixedVector)
+                    FeatureObserver::observe(document->domWindow(), FeatureObserver::UnprefixedTransitionEndEvent);
+            }
+        }
+    }
+
     return !event->defaultPrevented();
 }

trunk/Source/WebCore/page/FeatureObserver.h

@@ -58 +58 @@
         ContentSecurityPolicyReportOnly,
         PrefixedContentSecurityPolicyReportOnly,
+        PrefixedTransitionEndEvent,
+        UnprefixedTransitionEndEvent,
+        PrefixedAndUnprefixedTransitionEndEvent,
         // Add new features above this line.
         NumberOfFeatures, // This enum value must be last.