Changeset 139934 in webkit

Timestamp:

Jan 16, 2013 4:37:39 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Explicitly set msvs_cygwin_shell to true for bison rule
​https://bugs.webkit.org/show_bug.cgi?id=107058

Patch by Robert Iannucci <​iannucci@chromium.org> on 2013-01-16
Reviewed by Tony Chang.

Currently, msvs_cygwin_shell is set to 1 by default. This patch
explicitly sets it on the actions which will break if msvs_cygwin_shell
were set to 0. This is in preparation for changing the default value of
msvs_cygwin_shell, which in turn is in preparation of the removal of
cygwin as a buld-system requirement.

Since this change will have no semantic effect, no new tests are
required.

A previous instance of this bug is here:
​https://bugs.webkit.org/show_bug.cgi?id=106706

• WebCore.gyp/WebCore.gyp:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• WebCore.gyp/WebCore.gyp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-16  Robert Iannucci  <iannucci@chromium.org>
+
+        Explicitly set msvs_cygwin_shell to true for bison rule
+        https://bugs.webkit.org/show_bug.cgi?id=107058
+
+        Reviewed by Tony Chang.
+
+        Currently, msvs_cygwin_shell is set to 1 by default. This patch
+        explicitly sets it on the actions which will break if msvs_cygwin_shell
+        were set to 0. This is in preparation for changing the default value of
+        msvs_cygwin_shell, which in turn is in preparation of the removal of
+        cygwin as a buld-system requirement.
+
+        Since this change will have no semantic effect, no new tests are
+        required.
+
+        A previous instance of this bug is here:
+        https://bugs.webkit.org/show_bug.cgi?id=106706
+
+        * WebCore.gyp/WebCore.gyp:
+
 2013-01-16  Benjamin Poulain  <bpoulain@apple.com>
 

trunk/Source/WebCore/WebCore.gyp/WebCore.gyp

@@ -1147 +1147 @@
             '<(bison_exe)',
           ],
+          'msvs_cygwin_shell': 1,
         },
         {