Changeset 139936 in webkit

Timestamp:

Jan 16, 2013 4:48:14 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

start-queue.sh does not pass remaining parameters correctly
​https://bugs.webkit.org/show_bug.cgi?id=107054

Patch by Alan Cutter <​alancutter@chromium.org> on 2013-01-16
Reviewed by Adam Barth.

start-queue.sh now passes all remaining params to the webkit-patch command.
Previously only one additional queue parameter could be sent.

• EWSTools/start-queue.sh:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• EWSTools/start-queue.sh (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2013-01-16  Alan Cutter  <alancutter@chromium.org>
+
+        start-queue.sh does not pass remaining parameters correctly
+        https://bugs.webkit.org/show_bug.cgi?id=107054
+
+        Reviewed by Adam Barth.
+
+        start-queue.sh now passes all remaining params to the webkit-patch command.
+        Previously only one additional queue parameter could be sent.
+
+        * EWSTools/start-queue.sh:
+
 2013-01-16  Xueqing Huang  <huangxueqing@baidu.com>
 

trunk/Tools/EWSTools/start-queue.sh

@@ -28 +28 @@
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-# The GCE VM image we're using only has bash v4.1.5
-if test $# -lt 3 -o $# -gt 4; then
+if [[ $# -lt 3 ]]; then
     echo "Usage: start-queue-loop.sh QUEUE_NAME BOT_ID RESET_AFTER_ITERATION [QUEUE_PARAMS]"
     exit 1
@@ -37 +36 @@
 BOT_ID=$2
 RESET_AFTER_ITERATION=$3
-QUEUE_PARAMS=$4
+shift 3
+QUEUE_PARAMS="$@"
 
 cd /mnt/git/webkit-$QUEUE_NAME