Changeset 139954 in webkit

Timestamp:

Jan 16, 2013 7:42:09 PM (11 years ago)

Author:

abarth@webkit.org

Message:

Address tonyg's feedback on BackgroundHTMLParser
​https://bugs.webkit.org/show_bug.cgi?id=107086

Reviewed by Tony Gentilcore.

As requested in ​https://bugs.webkit.org/show_bug.cgi?id=107083#c5

• html/parser/BackgroundHTMLParser.cpp:

(WebCore::BackgroundHTMLParser::pumpTokenizer):
(TokenDelivery):
(WebCore::TokenDelivery::TokenDelivery):
(WebCore::TokenDelivery::execute):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/parser/BackgroundHTMLParser.cpp (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-16  Adam Barth  <abarth@webkit.org>
+
+        Address tonyg's feedback on BackgroundHTMLParser
+        https://bugs.webkit.org/show_bug.cgi?id=107086
+
+        Reviewed by Tony Gentilcore.
+
+        As requested in https://bugs.webkit.org/show_bug.cgi?id=107083#c5
+
+        * html/parser/BackgroundHTMLParser.cpp:
+        (WebCore::BackgroundHTMLParser::pumpTokenizer):
+        (TokenDelivery):
+        (WebCore::TokenDelivery::TokenDelivery):
+        (WebCore::TokenDelivery::execute):
+
 2013-01-16  Tony Gentilcore  <tonyg@chromium.org>
 

trunk/Source/WebCore/html/parser/BackgroundHTMLParser.cpp

@@ -104 +104 @@
         return;
 
+    // It's unclear whether we want to use AtomicStrings on the background
+    // thread. We will likely eventually use libdispatch to schedule parsing
+    // in a separate sequenced queue for each HTMLDocumentParser instance.
+    // Once we do that, the code below will be unsafe because libdispatch
+    // might schedule us on many different threads.
     DEFINE_STATIC_LOCAL(AtomicString, iframeTag, ("iframe", AtomicString::ConstructFromLiteral));
     DEFINE_STATIC_LOCAL(AtomicString, mathTag, ("math", AtomicString::ConstructFromLiteral));
@@ -163 +168 @@
 
 class TokenDelivery {
+    WTF_MAKE_NONCOPYABLE(TokenDelivery);
 public:
+    TokenDelivery() { }
+
     ParserIdentifier identifier;
     Vector<CompactHTMLToken> tokens;
@@ -173 +181 @@
         if (parser)
             parser->didReceiveTokensFromBackgroundParser(delivery->tokens);
+        // FIXME: Ideally we wouldn't need to call delete manually. Instead
+        // we would like an API where the message queue owns the tasks and
+        // takes care of deleting them.
         delete delivery;
     }