Changeset 140107 in webkit

Timestamp:

Jan 18, 2013 1:13:17 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: [Network] Fix JSDocs and deduplicate code.
​https://bugs.webkit.org/show_bug.cgi?id=107116

Patch by Eugene Klyuchnikov <​eustas@chromium.org> on 2013-01-18
Reviewed by Pavel Feldman.

Add / fix JSDocs to see possible type mismatches.
Deduplicate code for styling network log items.

• inspector/front-end/NetworkPanel.js: Fix JSDocs.

(WebInspector.NetworkDataGridNode.prototype._updateElementStyleClasses):
Extract common code.

• inspector/front-end/NetworkRequest.js: Fix JSDocs.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/NetworkPanel.js (modified) (8 diffs)
• inspector/front-end/NetworkRequest.js (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-18  Eugene Klyuchnikov  <eustas@chromium.org>
+
+        Web Inspector: [Network] Fix JSDocs and deduplicate code.
+        https://bugs.webkit.org/show_bug.cgi?id=107116
+
+        Reviewed by Pavel Feldman.
+
+        Add / fix JSDocs to see possible type mismatches.
+        Deduplicate code for styling network log items.
+
+        * inspector/front-end/NetworkPanel.js: Fix JSDocs.
+        (WebInspector.NetworkDataGridNode.prototype._updateElementStyleClasses):
+        Extract common code.
+        * inspector/front-end/NetworkRequest.js: Fix JSDocs.
+
 2013-01-18  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/Source/WebCore/inspector/front-end/NetworkPanel.js

@@ -423 +423 @@
             var requestTransferSize = (request.cached || !request.transferSize) ? 0 : request.transferSize;
             transferSize += requestTransferSize;
-            if ((!this._hiddenCategories.all || !this._hiddenCategories[request.type.name()]) && !this._filteredOutRequests.get(request)) {
+            if ((!this._hiddenCategories["all"] || !this._hiddenCategories[request.type.name()]) && !this._filteredOutRequests.get(request)) {
                 selectedRequestsNumber++;
                 selectedTransferSize += requestTransferSize;
@@ -1882 +1882 @@
  * @constructor
  * @extends {WebInspector.DataGridNode}
+ * @param {!WebInspector.NetworkLogView} parentView
+ * @param {!WebInspector.NetworkRequest} request
  */
 WebInspector.NetworkDataGridNode = function(parentView, request)
@@ -1912 +1914 @@
         if (this._parentView._filteredOutRequests.get(this._request))
             return true;
-        if (!this._parentView._hiddenCategories.all)
+        if (!this._parentView._hiddenCategories["all"])
             return false;
         return this._request.type.name() in this._parentView._hiddenCategories;
@@ -2016 +2018 @@
 
         this._element.addStyleClass("network-item");
-        if (!this._element.hasStyleClass("network-type-" + this._request.type.name())) {
-            this._element.removeMatchingStyleClasses("network-type-\\w+");
-            this._element.addStyleClass("network-type-" + this._request.type.name());
+        this._updateElementStyleClasses(this._element);
+    },
+
+    /**
+     * @param {!Element} element
+     */
+    _updateElementStyleClasses: function(element)
+    {
+        var typeClassName = "network-type-" + this._request.type.name();
+        if (!element.hasStyleClass(typeClassName)) {
+            element.removeMatchingStyleClasses("network-type-\\w+");
+            element.addStyleClass(typeClassName);
         }
     },
@@ -2066 +2077 @@
 
         if (this._request.statusCode) {
-            this._statusCell.appendChild(document.createTextNode(this._request.statusCode));
+            this._statusCell.appendChild(document.createTextNode("" + this._request.statusCode));
             this._appendSubtitle(this._statusCell, this._request.statusText);
             this._statusCell.title = this._request.statusCode + " " + this._request.statusText;
@@ -2110 +2121 @@
         this._initiatorCell.removeStyleClass("network-script-initiated");
         delete this._initiatorCell.request;
-        this._initiatorCell.title = null;
+        this._initiatorCell.title = "";
 
         var initiator = this._request.initiator;
         if ((initiator && initiator.type !== "other") || this._request.redirectSource) {
             this._initiatorCell.removeChildren();
-            if (this._request.redirectSource) {
-                var redirectSource = this._request.redirectSource;
+            var redirectSource = this._request.redirectSource;
+            if (redirectSource) {
                 this._initiatorCell.title = redirectSource.url;
                 this._initiatorCell.appendChild(WebInspector.linkifyRequestAsNode(redirectSource));
@@ -2129 +2140 @@
                 }
                 var urlElement = this._parentView._linkifier.linkifyLocation(topFrame.url, topFrame.lineNumber - 1, 0);
-                urlElement.title = null;
+                urlElement.title = "";
                 this._initiatorCell.appendChild(urlElement);
                 this._appendSubtitle(this._initiatorCell, WebInspector.UIString("Script"));
@@ -2185 +2196 @@
 
         this._barAreaElement.removeStyleClass("hidden");
-
-        if (!this._graphElement.hasStyleClass("network-type-" + this._request.type.name())) {
-            this._graphElement.removeMatchingStyleClasses("network-type-\\w+");
-            this._graphElement.addStyleClass("network-type-" + this._request.type.name());
-        }
+        this._updateElementStyleClasses(this._graphElement);
 
         this._barLeftElement.style.setProperty("left", percentages.start + "%");

trunk/Source/WebCore/inspector/front-end/NetworkRequest.js

@@ -433 +433 @@
 
     /**
-     * @return {WebInspector.Resource|undefined}
+     * @return {?WebInspector.NetworkRequest}
      */
     get redirectSource()