Changeset 140120 in webkit

Timestamp:

Jan 18, 2013 3:48:35 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: fix Closure r2388 warnings
​https://bugs.webkit.org/show_bug.cgi?id=107252

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-01-18
Reviewed by Pavel Feldman.

Surround all casts with brackets to avoid Closure warnings.

No new tests: no change in behaviour.

• inspector/front-end/BottomUpProfileDataGridTree.js:

(WebInspector.BottomUpProfileDataGridTree):

• inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.prototype._filteredBreakpointLocations):
(WebInspector.BreakpointManager.prototype.toggleAllBreakpoints):
(WebInspector.BreakpointManager.prototype.removeAllBreakpoints):

• inspector/front-end/DOMAgent.js:

(WebInspector.DOMAgent.prototype.pushNodeToFrontend):
(WebInspector.DOMAgent.prototype.pushNodeByPathToFrontend):
(WebInspector.DOMAgent.prototype.querySelector):
(WebInspector.DOMAgent.prototype.querySelectorAll):

• inspector/front-end/DefaultScriptMapping.js:

(WebInspector.DefaultScriptMapping.prototype._scriptEdited):

• inspector/front-end/ScriptSnippetModel.js:

(WebInspector.SnippetScriptMapping.prototype.rawLocationToUILocation):

• inspector/front-end/TopDownProfileDataGridTree.js:

(WebInspector.TopDownProfileDataGridTree):
(WebInspector.TopDownProfileDataGridTree.prototype.exclude):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/BottomUpProfileDataGridTree.js (modified) (1 diff)
• inspector/front-end/BreakpointManager.js (modified) (3 diffs)
• inspector/front-end/DOMAgent.js (modified) (5 diffs)
• inspector/front-end/DefaultScriptMapping.js (modified) (1 diff)
• inspector/front-end/ScriptSnippetModel.js (modified) (1 diff)
• inspector/front-end/TopDownProfileDataGridTree.js (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-18  Andrey Lushnikov  <lushnikov@chromium.org>
+
+        Web Inspector: fix Closure r2388 warnings
+        https://bugs.webkit.org/show_bug.cgi?id=107252
+
+        Reviewed by Pavel Feldman.
+
+        Surround all casts with brackets to avoid Closure warnings.
+
+        No new tests: no change in behaviour.
+
+        * inspector/front-end/BottomUpProfileDataGridTree.js:
+        (WebInspector.BottomUpProfileDataGridTree):
+        * inspector/front-end/BreakpointManager.js:
+        (WebInspector.BreakpointManager.prototype._filteredBreakpointLocations):
+        (WebInspector.BreakpointManager.prototype.toggleAllBreakpoints):
+        (WebInspector.BreakpointManager.prototype.removeAllBreakpoints):
+        * inspector/front-end/DOMAgent.js:
+        (WebInspector.DOMAgent.prototype.pushNodeToFrontend):
+        (WebInspector.DOMAgent.prototype.pushNodeByPathToFrontend):
+        (WebInspector.DOMAgent.prototype.querySelector):
+        (WebInspector.DOMAgent.prototype.querySelectorAll):
+        * inspector/front-end/DefaultScriptMapping.js:
+        (WebInspector.DefaultScriptMapping.prototype._scriptEdited):
+        * inspector/front-end/ScriptSnippetModel.js:
+        (WebInspector.SnippetScriptMapping.prototype.rawLocationToUILocation):
+        * inspector/front-end/TopDownProfileDataGridTree.js:
+        (WebInspector.TopDownProfileDataGridTree):
+        (WebInspector.TopDownProfileDataGridTree.prototype.exclude):
+
 2013-01-18  Takashi Sakamoto  <tasak@google.com>
 

trunk/Source/WebCore/inspector/front-end/BottomUpProfileDataGridTree.js

@@ -209 +209 @@
 
     // Populate the top level nodes.
-    var any = /** @type{*} */this;
-    var node = /** @type{WebInspector.ProfileDataGridNode} */any;
+    var any = /** @type{*} */(this);
+    var node = /** @type{WebInspector.ProfileDataGridNode} */(any);
     WebInspector.BottomUpProfileDataGridNode.prototype._populate.call(node);
 

trunk/Source/WebCore/inspector/front-end/BreakpointManager.js

@@ -160 +160 @@
     {
         var result = [];
-        var breakpoints = /** @type {Array.<WebInspector.BreakpointManager.Breakpoint>} */ this._breakpoints.keys();
+        var breakpoints = /** @type {Array.<WebInspector.BreakpointManager.Breakpoint>} */(this._breakpoints.keys());
         for (var i = 0; i < breakpoints.length; ++i) {
             var breakpoint = breakpoints[i];
@@ -199 +199 @@
     toggleAllBreakpoints: function(toggleState)
     {
-        var breakpoints = /** @type {Array.<WebInspector.BreakpointManager.Breakpoint>} */ this._breakpoints.keys();
+        var breakpoints = /** @type {Array.<WebInspector.BreakpointManager.Breakpoint>} */(this._breakpoints.keys());
         for (var i = 0; i < breakpoints.length; ++i) {
             var breakpoint = breakpoints[i];
@@ -209 +209 @@
     removeAllBreakpoints: function()
     {
-        var breakpoints = /** @type {Array.<WebInspector.BreakpointManager.Breakpoint>} */ this._breakpoints.keys();
+        var breakpoints = /** @type {Array.<WebInspector.BreakpointManager.Breakpoint>} */(this._breakpoints.keys());
         for (var i = 0; i < breakpoints.length; ++i)
             breakpoints[i].remove();

trunk/Source/WebCore/inspector/front-end/DOMAgent.js

@@ -894 +894 @@
     pushNodeToFrontend: function(objectId, callback)
     {
-        var callbackCast = /** @type {function(*)} */ callback;
+        var callbackCast = /** @type {function(*)} */(callback);
         this._dispatchWhenDocumentAvailable(DOMAgent.requestNode.bind(DOMAgent, objectId), callbackCast);
     },
@@ -904 +904 @@
     pushNodeByPathToFrontend: function(path, callback)
     {
-        var callbackCast = /** @type {function(*)} */ callback;
+        var callbackCast = /** @type {function(*)} */(callback);
         this._dispatchWhenDocumentAvailable(DOMAgent.pushNodeByPathToFrontend.bind(DOMAgent, path), callbackCast);
     },
@@ -933 +933 @@
     _dispatchWhenDocumentAvailable: function(func, callback)
     {
-        var callbackWrapper = /** @type {function(?Protocol.Error, *=)} */ this._wrapClientCallback(callback);
+        var callbackWrapper = /** @type {function(?Protocol.Error, *=)} */(this._wrapClientCallback(callback));
 
         function onDocumentAvailable()
@@ -1210 +1210 @@
     querySelector: function(nodeId, selectors, callback)
     {
-        var callbackCast = /** @type {function(*)|undefined} */callback;
+        var callbackCast = /** @type {function(*)|undefined} */(callback);
         DOMAgent.querySelector(nodeId, selectors, this._wrapClientCallback(callbackCast));
     },
@@ -1221 +1221 @@
     querySelectorAll: function(nodeId, selectors, callback)
     {
-        var callbackCast = /** @type {function(*)|undefined} */callback;
+        var callbackCast = /** @type {function(*)|undefined} */(callback);
         DOMAgent.querySelectorAll(nodeId, selectors, this._wrapClientCallback(callbackCast));
     },

trunk/Source/WebCore/inspector/front-end/DefaultScriptMapping.js

@@ -95 +95 @@
     _scriptEdited: function(scriptId, event)
     {
-        var content = /** @type {string} */ event.data;
+        var content = /** @type {string} */(event.data);
         this._uiSourceCodeForScriptId[scriptId].addRevision(content);
     },

trunk/Source/WebCore/inspector/front-end/ScriptSnippetModel.js

@@ -474 +474 @@
     rawLocationToUILocation: function(rawLocation)
     {
-        var debuggerModelLocation = /** @type {WebInspector.DebuggerModel.Location} */ rawLocation;
+        var debuggerModelLocation = /** @type {WebInspector.DebuggerModel.Location} */(rawLocation);
         return this._scriptSnippetModel._rawLocationToUILocation(debuggerModelLocation);
     },

trunk/Source/WebCore/inspector/front-end/TopDownProfileDataGridTree.js

@@ -81 +81 @@
     this._remainingChildren = profileNode.children;
 
-    var any = /** @type{*} */this;
-    var node = /** @type{WebInspector.ProfileDataGridNode} */any;
+    var any = /** @type{*} */(this);
+    var node = /** @type{WebInspector.ProfileDataGridNode} */(any);
     WebInspector.TopDownProfileDataGridNode.prototype._populate.call(node);
 }
@@ -108 +108 @@
         var excludedCallUID = profileDataGrideNode.callUID;
 
-        var any = /** @type{*} */this;
-        var node = /** @type{WebInspector.TopDownProfileDataGridNode} */any;
+        var any = /** @type{*} */(this);
+        var node = /** @type{WebInspector.TopDownProfileDataGridNode} */(any);
         WebInspector.TopDownProfileDataGridNode.prototype._exclude.call(node, excludedCallUID);