Changeset 140191 in webkit


Ignore:
Timestamp:
Jan 18, 2013 11:58:16 AM (11 years ago)
Author:
commit-queue@webkit.org
Message:

[BlackBerry] When acquiring/releasing backing store memory, allow web page client control suspend/resuming of backing store
​https://bugs.webkit.org/show_bug.cgi?id=107307

Patch by Andrew Lo <​anlo@rim.com> on 2013-01-18
Reviewed by Rob Buis.
Internally reviewed by Jakob Petsovits.

Internal PR276660
Have BackingStore::createBackingStoreMemory & releaseBackingStoreMemory only
acquire & release the surface pool. It doesn't matter if either is called
redundantly since SurfacePool has internal state to protect against that.

Resuming & suspending backing store and screen updates will be handled by
the WebPageClient.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStore::acquireBackingStoreMemory):
(BlackBerry::WebKit::BackingStore::releaseOwnedBackingStoreMemory):

  • Api/BackingStore.h:
Location:
trunk/Source/WebKit/blackberry
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit/blackberry/Api/BackingStore.cpp

    r140128 r140191  
    24562456}
    24572457
    2458 void BackingStore::createBackingStoreMemory()
    2459 {
    2460     if (BackingStorePrivate::s_currentBackingStoreOwner == d->m_webPage)
    2461         SurfacePool::globalSurfacePool()->createBuffers();
    2462     resumeBackingStoreUpdates();
    2463     resumeScreenUpdates(BackingStore::RenderAndBlit);
    2464 }
    2465 
    2466 void BackingStore::releaseBackingStoreMemory()
    2467 {
    2468     suspendBackingStoreUpdates();
    2469     suspendScreenUpdates();
     2458void BackingStore::acquireBackingStoreMemory()
     2459{
     2460    SurfacePool::globalSurfacePool()->createBuffers();
     2461}
     2462
     2463void BackingStore::releaseOwnedBackingStoreMemory()
     2464{
    24702465    if (BackingStorePrivate::s_currentBackingStoreOwner == d->m_webPage)
    24712466        SurfacePool::globalSurfacePool()->releaseBuffers();

  • trunk/Source/WebKit/blackberry/Api/BackingStore.h

    r138539 r140191  
    7272    bool isDirectRenderingToWindow() const;
    7373
    74     void createBackingStoreMemory();
    75     void releaseBackingStoreMemory();
     74    void acquireBackingStoreMemory();
     75    void releaseOwnedBackingStoreMemory();
    7676
    7777    void drawContents(Platform::Graphics::Drawable*, const Platform::IntRect& /*contentsRect*/, const Platform::IntSize& /*destinationSize*/);

  • trunk/Source/WebKit/blackberry/ChangeLog

    r140170 r140191  
     12013-01-18  Andrew Lo  <anlo@rim.com>
     2
     3        [BlackBerry] When acquiring/releasing backing store memory, allow web page client control suspend/resuming of backing store
     4        https://bugs.webkit.org/show_bug.cgi?id=107307
     5
     6        Reviewed by Rob Buis.
     7        Internally reviewed by Jakob Petsovits.
     8
     9        Internal PR276660
     10        Have BackingStore::createBackingStoreMemory & releaseBackingStoreMemory only
     11        acquire & release the surface pool. It doesn't matter if either is called
     12        redundantly since SurfacePool has internal state to protect against that.
     13
     14        Resuming & suspending backing store and screen updates will be handled by
     15        the WebPageClient.
     16
     17        * Api/BackingStore.cpp:
     18        (BlackBerry::WebKit::BackingStore::acquireBackingStoreMemory):
     19        (BlackBerry::WebKit::BackingStore::releaseOwnedBackingStoreMemory):
     20        * Api/BackingStore.h:
     21
    1222013-01-18  Nima Ghanavatian  <nghanavatian@rim.com>
    223
Note: See TracChangeset for help on using the changeset viewer.