Changeset 140208 in webkit


Ignore:
Timestamp:
Jan 18, 2013 2:21:22 PM (11 years ago)
Author:
robert@webkit.org
Message:

fast/inline/fixed-pos-moves-with-abspos-parent-relative-ancestor.html is crashing after r140024
https://bugs.webkit.org/show_bug.cgi?id=107209

Reviewed by David Hyatt.

Source/WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutPositionedObjects): r140024 forgot to layout the fixedpos object after
marking it.

LayoutTests:

  • platform/chromium/TestExpectations:
Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r140207 r140208  
     12013-01-18  Robert Hogan  <robert@webkit.org>
     2
     3        fast/inline/fixed-pos-moves-with-abspos-parent-relative-ancestor.html is crashing after r140024
     4        https://bugs.webkit.org/show_bug.cgi?id=107209
     5
     6        Reviewed by David Hyatt.
     7
     8        * platform/chromium/TestExpectations:
     9
    1102013-01-18  Alpha Lam  <hclam@chromium.org>
    211
  • trunk/LayoutTests/platform/chromium/TestExpectations

    r140202 r140208  
    43254325webkit.org/b/107204 fast/events/touch/multi-touch-inside-iframes.html [ Pass Failure ]
    43264326
    4327 webkit.org/b/107209 [ Debug ] fast/inline/fixed-pos-moves-with-abspos-parent-relative-ancestor.html [ Crash ]
    43284327webkit.org/b/107316 [ Mac Debug ] fast/inline/fixed-pos-moves-with-abspos-inline-parent.html [ Failure ]
    43294328
  • trunk/Source/WebCore/ChangeLog

    r140206 r140208  
     12013-01-18  Robert Hogan  <robert@webkit.org>
     2
     3        fast/inline/fixed-pos-moves-with-abspos-parent-relative-ancestor.html is crashing after r140024
     4        https://bugs.webkit.org/show_bug.cgi?id=107209
     5
     6        Reviewed by David Hyatt.
     7
     8        * rendering/RenderBlock.cpp:
     9        (WebCore::RenderBlock::layoutPositionedObjects): r140024 forgot to layout the fixedpos object after
     10        marking it.
     11
    1122013-01-18  Abhishek Arya  <inferno@chromium.org>
    213
  • trunk/Source/WebCore/rendering/RenderBlock.cpp

    r140171 r140208  
    26582658        // it has static position.
    26592659        markFixedPositionObjectForLayoutIfNeeded(r);
    2660         if (fixedPositionObjectsOnly)
     2660        if (fixedPositionObjectsOnly) {
     2661            r->layoutIfNeeded();
    26612662            continue;
     2663        }
    26622664
    26632665        // When a non-positioned block element moves, it may have positioned children that are implicitly positioned relative to the
Note: See TracChangeset for help on using the changeset viewer.