Changeset 140258 in webkit

Timestamp:

Jan 19, 2013 1:11:31 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

[WK2] svg/dom/fuzz-path-parser.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=107133

Patch by Zan Dobersek <​zdobersek@igalia.com> on 2013-01-19
Reviewed by Alexey Proskuryakov.

Tools:

Console messages can contain null characters before the end of string.
Appending such message to the StringBuilder as a WTFString appends the
complete string, including the null character. This later cuts off everything
after the null character when the string is being printed out to the test
output.

To avoid this, truncate the string up to the first null character. This
preserves the newline character appended immediately after this and
stops giving incorrect output.

• WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::willAddMessageToConsole):

LayoutTests:

Unskip the now-passing test.

• platform/gtk-wk2/TestExpectations:
• platform/wk2/TestExpectations:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/gtk-wk2/TestExpectations (modified) (1 diff)
• LayoutTests/platform/wk2/TestExpectations (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-01-19  Zan Dobersek  <zdobersek@igalia.com>
+
+        [WK2] svg/dom/fuzz-path-parser.html is failing
+        https://bugs.webkit.org/show_bug.cgi?id=107133
+
+        Reviewed by Alexey Proskuryakov.
+
+        Unskip the now-passing test.
+
+        * platform/gtk-wk2/TestExpectations:
+        * platform/wk2/TestExpectations:
+
 2013-01-19  Dominik Röttsches  <dominik.rottsches@intel.com>
 

trunk/LayoutTests/platform/gtk-wk2/TestExpectations

@@ -339 +339 @@
 Bug(GTK) svg/custom/pointer-events-on-svg-with-pointer.xhtml [ Failure Pass ]
 Bug(GTK) svg/custom/pointer-events-on-svg-without-pointer.xhtml [ Failure Pass ]
-Bug(WK2) svg/dom/fuzz-path-parser.html [ Failure ]
 Bug(WK2) svg/hixie/cascade/002.xml [ Failure ]
 Bug(GTK) svg/stroke/non-scaling-stroke-pattern.svg [ ImageOnlyFailure Pass ]

trunk/LayoutTests/platform/wk2/TestExpectations

@@ -682 +682 @@
 storage/websql/open-database-while-transaction-in-progress.html
 svg/custom/clip-path-referencing-use2.svg
-svg/dom/fuzz-path-parser.html
 svg/hixie/cascade/002.xml
 tables/mozilla_expected_failures/bugs/bug8499.html

trunk/Tools/ChangeLog

@@ +1 @@
+2013-01-19  Zan Dobersek  <zdobersek@igalia.com>
+
+        [WK2] svg/dom/fuzz-path-parser.html is failing
+        https://bugs.webkit.org/show_bug.cgi?id=107133
+
+        Reviewed by Alexey Proskuryakov.
+
+        Console messages can contain null characters before the end of string.
+        Appending such message to the StringBuilder as a WTFString appends the
+        complete string, including the null character. This later cuts off everything
+        after the null character when the string is being printed out to the test
+        output.
+
+        To avoid this, truncate the string up to the first null character. This
+        preserves the newline character appended immediately after this and
+        stops giving incorrect output.
+
+        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
+        (WTR::InjectedBundlePage::willAddMessageToConsole):
+
 2013-01-19  Eric Seidel  <eric@webkit.org>
 

trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp

@@ -1431 +1431 @@
 
     WTF::String messageString = toWTFString(message);
+    unsigned nullCharPos = messageString.find(UChar(0));
+    if (nullCharPos != WTF::notFound)
+        messageString.truncate(nullCharPos);
+
     size_t fileProtocolStart = messageString.find("file://");
     if (fileProtocolStart != WTF::notFound)