Changeset 140270 in webkit
- Timestamp:
- Jan 20, 2013 2:35:00 AM (11 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r140267 r140270 1 2013-01-20 Kentaro Hara <haraken@chromium.org> 2 3 [V8] Create a persistent wrapper for Window.prototype and innerGlobalObject 4 https://bugs.webkit.org/show_bug.cgi?id=107253 5 6 Reviewed by Adam Barth. 7 8 This is one of steps to avoid hitting an ASSERT() 9 that will be added in https://bugs.webkit.org/show_bug.cgi?id=107137 . 10 We should have a persistent wrapper for all DOM objects 11 and set a class id on the wrapper. 12 13 No tests. No change in behavior. 14 15 * bindings/v8/V8DOMWindowShell.cpp: 16 (WebCore::V8DOMWindowShell::installDOMWindow): 17 1 18 2013-01-19 Philip Rogers <pdr@google.com> 2 19 -
trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp
r139900 r140270 318 318 V8DOMWindow::installPerContextProperties(windowWrapper, window); 319 319 320 V8DOMWrapper:: setNativeInfo(v8::Handle<v8::Object>::Cast(windowWrapper->GetPrototype()), &V8DOMWindow::info, window);320 V8DOMWrapper::associateObjectWithWrapper(PassRefPtr<DOMWindow>(window), &V8DOMWindow::info, v8::Handle<v8::Object>::Cast(windowWrapper->GetPrototype()), m_isolate); 321 321 322 322 // Install the windowWrapper as the prototype of the innerGlobalObject. … … 334 334 // 335 335 v8::Handle<v8::Object> innerGlobalObject = toInnerGlobalObject(m_context.get()); 336 V8DOMWrapper:: setNativeInfo(innerGlobalObject, &V8DOMWindow::info, window);336 V8DOMWrapper::associateObjectWithWrapper(PassRefPtr<DOMWindow>(window), &V8DOMWindow::info, innerGlobalObject, m_isolate); 337 337 innerGlobalObject->SetPrototype(windowWrapper); 338 338 V8DOMWrapper::associateObjectWithWrapper(PassRefPtr<DOMWindow>(window), &V8DOMWindow::info, windowWrapper, m_isolate);
Note: See TracChangeset
for help on using the changeset viewer.