Changeset 140288 in webkit

Timestamp:

Jan 20, 2013 6:29:56 PM (11 years ago)

Author:

haraken@chromium.org

Message:

Unreviewed, rolling out r140270.
​http://trac.webkit.org/changeset/140270
​https://bugs.webkit.org/show_bug.cgi?id=107253

Hit asserts in a debug build

• bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::installDOMWindow):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/v8/V8DOMWindowShell.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-20  Kentaro Hara  <haraken@chromium.org>
+
+        Unreviewed, rolling out r140270.
+        http://trac.webkit.org/changeset/140270
+        https://bugs.webkit.org/show_bug.cgi?id=107253
+
+        Hit asserts in a debug build
+
+        * bindings/v8/V8DOMWindowShell.cpp:
+        (WebCore::V8DOMWindowShell::installDOMWindow):
+
 2013-01-20  Shinya Kawanaka  <shinyak@chromium.org>
 

trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp

@@ -318 +318 @@
     V8DOMWindow::installPerContextProperties(windowWrapper, window);
 
-    V8DOMWrapper::associateObjectWithWrapper(PassRefPtr<DOMWindow>(window), &V8DOMWindow::info, v8::Handle<v8::Object>::Cast(windowWrapper->GetPrototype()), m_isolate);
+    V8DOMWrapper::setNativeInfo(v8::Handle<v8::Object>::Cast(windowWrapper->GetPrototype()), &V8DOMWindow::info, window);
 
     // Install the windowWrapper as the prototype of the innerGlobalObject.
@@ -334 +334 @@
     //
     v8::Handle<v8::Object> innerGlobalObject = toInnerGlobalObject(m_context.get());
-    V8DOMWrapper::associateObjectWithWrapper(PassRefPtr<DOMWindow>(window), &V8DOMWindow::info, innerGlobalObject, m_isolate);
+    V8DOMWrapper::setNativeInfo(innerGlobalObject, &V8DOMWindow::info, window);
     innerGlobalObject->SetPrototype(windowWrapper);
     V8DOMWrapper::associateObjectWithWrapper(PassRefPtr<DOMWindow>(window), &V8DOMWindow::info, windowWrapper, m_isolate);