Changeset 140327 in webkit

Timestamp:

Jan 21, 2013 5:55:36 AM (11 years ago)

Author:

Christophe Dumez

Message:

[EFL][WKTR] platformRunUntil() should keep the main loop running
​https://bugs.webkit.org/show_bug.cgi?id=107442

Reviewed by Noam Rosenthal.

EFL's implementation of platformRunUntil() should keep the main loop
running and avoid calling sleep() between calls to
ecore_main_loop_iterate(). This call to sleep seems to be a source
of deadlocks (see Bug 106884).

• WebKitTestRunner/efl/TestControllerEfl.cpp:

(WTR::TestController::platformRunUntil):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• WebKitTestRunner/efl/TestControllerEfl.cpp (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2013-01-21  Christophe Dumez  <christophe.dumez@intel.com>
+
+        [EFL][WKTR] platformRunUntil() should keep the main loop running
+        https://bugs.webkit.org/show_bug.cgi?id=107442
+
+        Reviewed by Noam Rosenthal.
+
+        EFL's implementation of platformRunUntil() should keep the main loop
+        running and avoid calling sleep() between calls to
+        ecore_main_loop_iterate(). This call to sleep seems to be a source
+        of deadlocks (see Bug 106884).
+
+        * WebKitTestRunner/efl/TestControllerEfl.cpp:
+        (WTR::TestController::platformRunUntil):
+
 2013-01-21  Vivek Galatage  <vivek.vg@samsung.com>
 

trunk/Tools/WebKitTestRunner/efl/TestControllerEfl.cpp

@@ -66 +66 @@
     if (timeout == m_noTimeout) {
         // Never timeout if we are debugging or not meant to timeout.
-        while (!condition) {
+        while (!condition)
             ecore_main_loop_iterate();
-            sleep(1);
-        }
+
         return;
     }