Changeset 140339 in webkit

Timestamp:

Jan 21, 2013 8:39:34 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

[GTK] Volume button should not be shown for videos without audio
​https://bugs.webkit.org/show_bug.cgi?id=106436

Patch by Halton Huo <​halton.huo@intel.com> on 2013-01-21
Reviewed by Philippe Normand.

The volume control is no longer shown for videos with no audio.

No new tests, tested by media/video-no-audio.html.

• platform/gtk/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::hasOwnDisabledStateHandlingFor):
(WebCore):

• platform/gtk/RenderThemeGtk.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/gtk/RenderThemeGtk.cpp (modified) (1 diff)
• platform/gtk/RenderThemeGtk.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-21  Halton Huo  <halton.huo@intel.com>
+
+        [GTK] Volume button should not be shown for videos without audio
+        https://bugs.webkit.org/show_bug.cgi?id=106436
+
+        Reviewed by Philippe Normand.
+
+        The volume control is no longer shown for videos with no audio.
+
+        No new tests, tested by media/video-no-audio.html.
+
+        * platform/gtk/RenderThemeGtk.cpp:
+        (WebCore::RenderThemeGtk::hasOwnDisabledStateHandlingFor):
+        (WebCore):
+        * platform/gtk/RenderThemeGtk.h:
+
 2013-01-21  Dan Winship  <danw@gnome.org>
 

trunk/Source/WebCore/platform/gtk/RenderThemeGtk.cpp

@@ -514 +514 @@
 }
 
+bool RenderThemeGtk::hasOwnDisabledStateHandlingFor(ControlPart part) const
+{
+    return (part != MediaMuteButtonPart);
+}
+
 bool RenderThemeGtk::paintMediaFullscreenButton(RenderObject* renderObject, const PaintInfo& paintInfo, const IntRect& rect)
 {

trunk/Source/WebCore/platform/gtk/RenderThemeGtk.h

@@ -163 +163 @@
     void initMediaButtons();
     void adjustMediaSliderThumbSize(RenderStyle*) const;
-    virtual bool hasOwnDisabledStateHandlingFor(ControlPart) const { return true; }
+    virtual bool hasOwnDisabledStateHandlingFor(ControlPart) const;
     virtual bool paintMediaFullscreenButton(RenderObject*, const PaintInfo&, const IntRect&);
     virtual bool paintMediaPlayButton(RenderObject*, const PaintInfo&, const IntRect&);