Changeset 140344 in webkit

Timestamp:

Jan 21, 2013 10:44:19 AM (11 years ago)

Author:

Christophe Dumez

Message:

Regression(r140262): Causes a lot of flakiness
​https://bugs.webkit.org/show_bug.cgi?id=107454

Reviewed by Alexey Proskuryakov.

r140262 introduced a lot of flakiness due to fixed layout mode
not getting disabled on the view after being enabled for
specific test cases. This patch makes sure fixed layout mode
properly gets reset in WebKitTestRunner to avoid flakiness.

• WebKitTestRunner/TestInvocation.cpp:

(WTR::updateLayoutType):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• WebKitTestRunner/TestInvocation.cpp (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2013-01-21  Christophe Dumez  <christophe.dumez@intel.com>
+
+        Regression(r140262): Causes a lot of flakiness
+        https://bugs.webkit.org/show_bug.cgi?id=107454
+
+        Reviewed by Alexey Proskuryakov.
+
+        r140262 introduced a lot of flakiness due to fixed layout mode
+        not getting disabled on the view after being enabled for
+        specific test cases. This patch makes sure fixed layout mode
+        properly gets reset in WebKitTestRunner to avoid flakiness.
+
+        * WebKitTestRunner/TestInvocation.cpp:
+        (WTR::updateLayoutType):
+
 2013-01-21  Gustavo Noronha Silva  <gns@gnome.org>
 

trunk/Tools/WebKitTestRunner/TestInvocation.cpp

@@ -193 +193 @@
 static void updateLayoutType(const char* pathOrURL)
 {
-    bool useFixedLayout = shouldUseFixedLayout(pathOrURL);
-    if (!useFixedLayout)
-        return;
-
     WKRetainPtr<WKMutableDictionaryRef> viewOptions = adoptWK(WKMutableDictionaryCreate());
     WKRetainPtr<WKStringRef> useFixedLayoutKey = adoptWK(WKStringCreateWithUTF8CString("UseFixedLayout"));
-    WKRetainPtr<WKBooleanRef> useFixedLayoutValue = adoptWK(WKBooleanCreate(useFixedLayout));
+    WKRetainPtr<WKBooleanRef> useFixedLayoutValue = adoptWK(WKBooleanCreate(shouldUseFixedLayout(pathOrURL)));
     WKDictionaryAddItem(viewOptions.get(), useFixedLayoutKey.get(), useFixedLayoutValue.get());