Changeset 140349 in webkit

Timestamp:

Jan 21, 2013 11:46:48 AM (11 years ago)

Author:

nghanavatian@rim.com

Message:

[BlackBerry] Skip spell checking on single character strings
​https://bugs.webkit.org/show_bug.cgi?id=107463

Reviewed by Yong Li.

Check for a minimum string length when firing off spellcheck since we don't
want to mark single letter words.

Internally reviewed by Mike Fenton.

• WebKitSupport/InputHandler.cpp:
• WebKitSupport/SpellingHandler.cpp:

(BlackBerry::WebKit::SpellingHandler::createSpellCheckRequest):
(BlackBerry::WebKit::SpellingHandler::parseBlockForSpellChecking):

Location:

trunk/Source/WebKit/blackberry

Files:

• ChangeLog (modified) (1 diff)
• WebKitSupport/SpellingHandler.cpp (modified) (2 diffs)

trunk/Source/WebKit/blackberry/ChangeLog

@@ +1 @@
+2013-01-21  Nima Ghanavatian  <nghanavatian@rim.com>
+
+        [BlackBerry] Skip spell checking on single character strings
+        https://bugs.webkit.org/show_bug.cgi?id=107463
+
+        Reviewed by Yong Li.
+
+        Check for a minimum string length when firing off spellcheck since we don't
+        want to mark single letter words.
+
+        Internally reviewed by Mike Fenton.
+
+        * WebKitSupport/InputHandler.cpp:
+        * WebKitSupport/SpellingHandler.cpp:
+        (BlackBerry::WebKit::SpellingHandler::createSpellCheckRequest):
+        (BlackBerry::WebKit::SpellingHandler::parseBlockForSpellChecking):
+
 2013-01-20  Charles Wei  <charles.wei@torchmobile.com.cn>
 

trunk/Source/WebKit/blackberry/WebKitSupport/SpellingHandler.cpp

@@ -80 +80 @@
 {
     RefPtr<WebCore::Range> rangeForSpellChecking = rangeForSpellCheckingPtr;
-    if (isSpellCheckActive()) {
+    if (isSpellCheckActive() && rangeForSpellChecking->text().length() >= MinSpellCheckingStringLength)
         m_inputHandler->callRequestCheckingFor(SpellCheckRequest::create(TextCheckingTypeSpelling, textCheckingProcessType, rangeForSpellChecking, rangeForSpellChecking));
-        m_timer.startOneShot(s_timeout);
-    }
 }
 
@@ -122 +120 @@
     // Call spellcheck with substring.
     createSpellCheckRequest(rangeForSpellChecking, m_textCheckingProcessType);
+    if (isSpellCheckActive())
+        m_timer.startOneShot(s_timeout);
 }