Changeset 140367 in webkit

Timestamp:

Jan 21, 2013 2:45:29 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Enable process suppression by default on Mac
​https://bugs.webkit.org/show_bug.cgi?id=106804

Patch by Kiran Muppala <​cmuppala@apple.com> on 2013-01-21
Reviewed by Alexey Proskuryakov.

• UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext): Change initialized value of
m_processSuppressionEnabled from false to true.

• UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformInitialize): Since process suppression
is no longer disabled on construction, do not disable it for global
child processes either. Instead enable occlusion notifications as
they are needed to trigger process suppression.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebContext.cpp (modified) (1 diff)
• UIProcess/mac/WebContextMac.mm (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2013-01-21  Kiran Muppala  <cmuppala@apple.com>
+
+        Enable process suppression by default on Mac
+        https://bugs.webkit.org/show_bug.cgi?id=106804
+
+        Reviewed by Alexey Proskuryakov.
+
+        * UIProcess/WebContext.cpp:
+        (WebKit::WebContext::WebContext): Change initialized value of
+        m_processSuppressionEnabled from false to true.
+        * UIProcess/mac/WebContextMac.mm:
+        (WebKit::WebContext::platformInitialize): Since process suppression
+        is no longer disabled on construction, do not disable it for global
+        child processes either.  Instead enable occlusion notifications as
+        they are needed to trigger process suppression.
+
 2013-01-17  Andy Estes  <aestes@apple.com>
 

trunk/Source/WebKit2/UIProcess/WebContext.cpp

@@ -143 +143 @@
 #endif
 #if PLATFORM(MAC)
-    , m_processSuppressionEnabled(false)
+    , m_processSuppressionEnabled(true)
 #endif
 #if USE(SOUP)

trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm

@@ -229 +229 @@
     registerUserDefaultsIfNeeded();
     registerNotificationObservers();
-    ASSERT(!m_processSuppressionEnabled);
-    disableProcessSuppressionForGlobalChildProcesses();
+    ASSERT(m_processSuppressionEnabled);
+    enableOcclusionNotifications();
 }