Changeset 140387 in webkit

Timestamp:

Jan 21, 2013 11:33:16 PM (11 years ago)

Author:

haraken@chromium.org

Message:

[V8] ScriptState::isolate() should use Context::GetIsolate()
​https://bugs.webkit.org/show_bug.cgi?id=107490

Reviewed by Adam Barth.

Now V8 provides Context::GetIsolate(). We should use it
in ScriptState::isolate().

• bindings/v8/ScriptState.h:

(WebCore::ScriptState::isolate):
(ScriptState):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/v8/ScriptState.h (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-21  Kentaro Hara  <haraken@chromium.org>
+
+        [V8] ScriptState::isolate() should use Context::GetIsolate()
+        https://bugs.webkit.org/show_bug.cgi?id=107490
+
+        Reviewed by Adam Barth.
+
+        Now V8 provides Context::GetIsolate(). We should use it
+        in ScriptState::isolate().
+
+        * bindings/v8/ScriptState.h:
+        (WebCore::ScriptState::isolate):
+        (ScriptState):
+
 2013-01-21  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
 

trunk/Source/WebCore/bindings/v8/ScriptState.h

@@ -66 +66 @@
     v8::Isolate* isolate()
     {
-        if (!m_isolate)
-            m_isolate = v8::Isolate::GetCurrent();
-        return m_isolate;
+        return m_context->GetIsolate();
     }
 
@@ -89 +87 @@
     v8::Local<v8::Value> m_exception;
     ScopedPersistent<v8::Context> m_context;
-    v8::Isolate* m_isolate;
 };