Changeset 140445 in webkit

Timestamp:

Jan 22, 2013 11:24:58 AM (11 years ago)

Author:

sergio@webkit.org

Message:

[Soup] Random thread crashes
​https://bugs.webkit.org/show_bug.cgi?id=107439

Reviewed by Martin Robinson.

Process all pending requests in the inner GMainContext created to
perform synchronous requests before restoring the thread default. No
new tests required, already covered by network tests.

• platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::WebCoreSynchronousLoader::~WebCoreSynchronousLoader):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/network/soup/ResourceHandleSoup.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-22  Sergio Villar Senin  <svillar@igalia.com>
+
+        [Soup] Random thread crashes
+        https://bugs.webkit.org/show_bug.cgi?id=107439
+
+        Reviewed by Martin Robinson.
+
+        Process all pending requests in the inner GMainContext created to
+        perform synchronous requests before restoring the thread default. No
+        new tests required, already covered by network tests.
+
+        * platform/network/soup/ResourceHandleSoup.cpp:
+        (WebCore::WebCoreSynchronousLoader::~WebCoreSynchronousLoader):
+
 2013-01-22  Christophe Dumez  <christophe.dumez@intel.com>
 

trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp

@@ -118 +118 @@
     {
         adjustMaxConnections(-1);
-        g_main_context_pop_thread_default(g_main_context_get_thread_default());
+
+        GMainContext* context = g_main_context_get_thread_default();
+        while (g_main_context_pending(context))
+            g_main_context_iteration(context, FALSE);
+
+        g_main_context_pop_thread_default(context);
         loadingSynchronousRequest = false;
     }