Changeset 140525 in webkit


Ignore:
Timestamp:
Jan 23, 2013 1:42:37 AM (11 years ago)
Author:
yosin@chromium.org
Message:

REGRESSION(r139044): Pan icon remains on screen on Chromium-WinXP
​https://bugs.webkit.org/show_bug.cgi?id=107623

Reviewed by Hajime Morita.

Source/WebCore:

The issue is caused by AutoscrollController::stopAutoscrollTimer()
doesn't call View::removePanScrollIcon() because m_autoscrollType
is reset before checking it.

This patch changes to reset m_autoscrollType after all references.

Test: platform/chromium-win/fast/events/panScroll-panIcon.html

  • page/AutoscrollController.cpp:

(WebCore::AutoscrollController::stopAutoscrollTimer):

LayoutTests:

This test checks no pan icon after pan scroll.

  • platform/chromium-win/fast/events/panScroll-panIcon-expected.png: Added.
  • platform/chromium-win/fast/events/panScroll-panIcon-expected.txt: Added.
  • platform/chromium-win/fast/events/panScroll-panIcon.html: Added.
  • platform/chromium/TestExpectations: Changed to skip entry for panScroll-panIcon.html for Android, Linux and Mac.
Location:
trunk
Files:
3 added
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r140522 r140525  
     12013-01-23  Yoshifumi Inoue  <yosin@chromium.org>
     2
     3        REGRESSION(r139044): Pan icon remains on screen on Chromium-WinXP
     4        https://bugs.webkit.org/show_bug.cgi?id=107623
     5
     6        Reviewed by Hajime Morita.
     7
     8        This test checks no pan icon after pan scroll.
     9
     10        * platform/chromium-win/fast/events/panScroll-panIcon-expected.png: Added.
     11        * platform/chromium-win/fast/events/panScroll-panIcon-expected.txt: Added.
     12        * platform/chromium-win/fast/events/panScroll-panIcon.html: Added.
     13        * platform/chromium/TestExpectations: Changed to skip entry for panScroll-panIcon.html for Android, Linux and Mac.
     14
    1152013-01-23  Vivek Galatage  <vivek.vg@samsung.com>
    216

  • trunk/LayoutTests/platform/chromium/TestExpectations

    r140502 r140525  
    20802080webkit.org/b/107205 [ Android Linux Mac ] platform/chromium-win/fast/events/panScroll-click.html [ Skip ]
    20812081webkit.org/b/107205 [ Android Linux Mac ] platform/chromium-win/fast/events/panScroll-drag.html [ Skip ]
     2082webkit.org/b/107623 [ Android Linux Mac ] platform/chromium-win/fast/events/panScroll-panIcon.html [ Skip ]
    20822083
    20832084crbug.com/31623 [ SnowLeopard Win ] http/tests/appcache/remove-cache.html [ Failure Pass Timeout ]

  • trunk/Source/WebCore/ChangeLog

    r140524 r140525  
     12013-01-23  Yoshifumi Inoue  <yosin@chromium.org>
     2
     3        REGRESSION(r139044): Pan icon remains on screen on Chromium-WinXP
     4        https://bugs.webkit.org/show_bug.cgi?id=107623
     5
     6        Reviewed by Hajime Morita.
     7
     8        The issue is caused by AutoscrollController::stopAutoscrollTimer()
     9        doesn't call View::removePanScrollIcon() because m_autoscrollType
     10        is reset before checking it.
     11
     12        This patch changes to reset m_autoscrollType after all references.
     13
     14        Test: platform/chromium-win/fast/events/panScroll-panIcon.html
     15
     16        * page/AutoscrollController.cpp:
     17        (WebCore::AutoscrollController::stopAutoscrollTimer):
     18
    1192013-01-23  Sergio Villar Senin  <svillar@igalia.com>
    220

  • trunk/Source/WebCore/page/AutoscrollController.cpp

    r140286 r140525  
    9191    RenderBox* scrollable = m_autoscrollRenderer;
    9292    m_autoscrollTimer.stop();
    93     m_autoscrollType = NoAutoscroll;
    9493    m_autoscrollRenderer = 0;
    9594
    … …  
    115114    }
    116115#endif
     116
     117    m_autoscrollType = NoAutoscroll;
    117118
    118119#if ENABLE(PAN_SCROLLING)
Note: See TracChangeset for help on using the changeset viewer.